Parth Shandilya

Results 98 comments of Parth Shandilya
trafficstars

I added the url detection for services, I was not sure on how the URL will look like for services other than github, so kept them as to do for...

@nijel One thing that we discussed earlier for multiple origin suggestions, Should I add multiple delete buttons for them or an Icon with delete functionality would be more intuitive. In...

The solution sounds good to me however it will result in more clicks required to delete an entry, imo it's not good for UX. Incase of the delete icon, the...

@nijel I worked on the proposed solution. Apologies for the delay. > The preferred solution as I see it now (feedback welcome): - [x] Collect the delete URLs at origin...

Thanks for review, I could reproduce 1 and 3. 1. The empty cell screenshot if delete button is not present. ![Screenshot 2022-09-18 at 15 26 42](https://user-images.githubusercontent.com/24358501/190907431-71985480-5d83-42da-871f-feaff1238fa6.png) 2. I couldn't reproduce...

@nijel Please let me know if there is something left for this PR. Thanks

@glehmann Are you done with the changes? Can you please update the PR. Thanks

@justalemon You can send the PR. We will have a look at it :+1:

Same behavior is observed here: https://user-images.githubusercontent.com/24358501/128350303-7ea4d646-0d8e-45ac-8f95-2bb93f34da4d.mov Related to react Searchkit