Rust_Search icon indicating copy to clipboard operation
Rust_Search copied to clipboard

feat: add flag to exclude directories from filtering

Open dolsem opened this issue 2 years ago • 10 comments

Currently if you apply filters to search it will ignore everything inside a directory that does not match a filter. So if you, for example. want to recursively find all files in the tree that have been modified today, it won't work. This is expect behavior of filter_entry(), see here.

This PR adds a flag to prevent applying filters to directories and only look at the files.

dolsem avatar Dec 17 '23 17:12 dolsem

@dolsem I decided to try Tauri, found this repository to implement the necessary functionality. I was very upset when I found this non-intuitive behavior. I'm waiting for your correction to be added

edwardgra4ev avatar Dec 20 '23 13:12 edwardgra4ev

I updated the PR renaming the flag to just dirs and removing directory entries from results when set to false. I think this makes more sense.

dolsem avatar Dec 22 '23 23:12 dolsem

I'd love to get feedback on the PR, if there is interest in merging it, I can update document this feature in the README as well.

dolsem avatar Dec 22 '23 23:12 dolsem

@dolsem There is a lot of interest. I am currently studying rust and tauri on my project using "Rust search" and your changes have helped me a lot in the project. Now in my project, "rust search" is taken from your fork

edwardgra4ev avatar Dec 23 '23 14:12 edwardgra4ev

@edwardgra4ev thank you, that's good to know. Hopefully there will be interest from maintainers as well, so that the PR can get merged.

dolsem avatar Dec 24 '23 04:12 dolsem

Hey guys, I created this repository solely to work as a search library for Verve. I'm working on other stuff currently and don't get much time to work on my open-source projects.

I'll merge these changes. Thanks for the contribution @dolsem and sorry for the delay @edwardgra4ev .

ParthJadhav avatar Dec 24 '23 07:12 ParthJadhav

Hey @dolsem , the builds are failing. Can you have a look?

ParthJadhav avatar Dec 24 '23 07:12 ParthJadhav

@ParthJadhav I'll update it today.

dolsem avatar Dec 24 '23 16:12 dolsem

@ParthJadhav I fixed all the broken tests

dolsem avatar Dec 26 '23 06:12 dolsem

@ParthJadhav any update?

dolsem avatar Jan 11 '24 16:01 dolsem