RoMa icon indicating copy to clipboard operation
RoMa copied to clipboard

About coordinates normalization

Open nnop opened this issue 8 months ago • 0 comments

Hi, Johan,

I have a question about the coordinates normalization in RoMa.

https://github.com/Parskatt/RoMa/blob/36389eff4089d7b3f4a752c054e8fd0714af7177/roma/models/matcher.py#L565-L572

As you're using colmap coordinate fasion, the left- and right-most pixel should be 0.5 and W-0.5. The current code is converting them to [-1+1/W, 1-1/W]. Shouldn't the conversion be: (2*x-1) / (W-1) - 1? That would make the left- and right-most pixel exactly [-1, 1].

nnop avatar Jun 23 '24 15:06 nnop