wp-parsely icon indicating copy to clipboard operation
wp-parsely copied to clipboard

Review Utils::get_page_on_front() returns bool

Open acicovic opened this issue 1 year ago • 1 comments

Is your request related to a problem?

We have this Utils::get_page_on_front() function, which is used by our Metadata->construct_metadata() function.

The Utils::get_page_on_front() name gives the impression that it could return a string (e.g. a page URL or slug) or an int (e.g. page ID). However, this function actually returns a bool. As such, it is either named inappropriately, or there is a better way to do things.

Describe the solution you'd like

Investigate if anything needs to be changed there.

acicovic avatar Oct 21 '24 12:10 acicovic

has_page_on_front()?

GaryJones avatar May 22 '25 15:05 GaryJones