pykafka icon indicating copy to clipboard operation
pykafka copied to clipboard

Fix tests for librdkafka 0.11.3+

Open carsonip opened this issue 6 years ago • 1 comments

Limit queued.max.messages.kbytes according to librdkafka https://github.com/edenhill/librdkafka/commit/cc43f451b46e41fc3ce00e3b4e5c9bafd11f7b0e.

This will fix rdkafka tests on librdkafka 0.11.3+.

E       RdKafkaException: Configuration property "queued.max.messages.kbytes" value 102400000 is outside allowed range 1..2097151

carsonip avatar Mar 17 '19 15:03 carsonip

Codecov Report

Merging #928 into master will increase coverage by 0.6%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #928     +/-   ##
=========================================
+ Coverage   83.21%   83.81%   +0.6%     
=========================================
  Files          36       36             
  Lines        3806     3807      +1     
  Branches      562      562             
=========================================
+ Hits         3167     3191     +24     
+ Misses        490      472     -18     
+ Partials      149      144      -5
Impacted Files Coverage Δ
pykafka/rdkafka/simple_consumer.py 89.47% <100%> (+0.09%) :arrow_up:
pykafka/handlers.py 91.17% <0%> (-1.48%) :arrow_down:
pykafka/balancedconsumer.py 90.05% <0%> (+0.29%) :arrow_up:
pykafka/broker.py 94.21% <0%> (+1.15%) :arrow_up:
pykafka/topic.py 80.41% <0%> (+2.06%) :arrow_up:
pykafka/cluster.py 73.62% <0%> (+2.19%) :arrow_up:
pykafka/simpleconsumer.py 87.05% <0%> (+2.45%) :arrow_up:
pykafka/connection.py 86.13% <0%> (+2.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3893c46...04d3c2e. Read the comment docs.

codecov-io avatar Mar 17 '19 15:03 codecov-io