pykafka icon indicating copy to clipboard operation
pykafka copied to clipboard

Documentation clarifications. Remove unused pykafka.common.Message.

Open DieterDePaepe opened this issue 6 years ago • 2 comments

#917

DieterDePaepe avatar Feb 28 '19 10:02 DieterDePaepe

Codecov Report

Merging #922 into master will increase coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   83.15%   83.32%   +0.17%     
==========================================
  Files          36       36              
  Lines        3799     3797       -2     
  Branches      562      562              
==========================================
+ Hits         3159     3164       +5     
+ Misses        493      487       -6     
+ Partials      147      146       -1
Impacted Files Coverage Δ
pykafka/topic.py 80.41% <ø> (-2.07%) :arrow_down:
pykafka/simpleconsumer.py 85.49% <ø> (-0.67%) :arrow_down:
pykafka/protocol/message.py 88.14% <100%> (ø) :arrow_up:
pykafka/common.py 100% <100%> (ø) :arrow_up:
pykafka/balancedconsumer.py 89.76% <0%> (-1.17%) :arrow_down:
pykafka/connection.py 83.16% <0%> (-1%) :arrow_down:
pykafka/handlers.py 91.91% <0%> (-0.74%) :arrow_down:
pykafka/cluster.py 72.52% <0%> (+0.36%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c816efa...b6f32b7. Read the comment docs.

codecov-io avatar Feb 28 '19 10:02 codecov-io

Looks great, thanks for the pull request. There are still a few instances of common.Message in docstrings, including in the protocol and in simpleconsumer.py. Once those are adjusted, this can be merged.

emmettbutler avatar Mar 04 '19 17:03 emmettbutler