pykafka icon indicating copy to clipboard operation
pykafka copied to clipboard

fix broken version comparison used during ssl tests

Open emmettbutler opened this issue 8 years ago • 2 comments

This pull request fixes a version comparison operation that caused ssl tests not to run under kafka 0.10.

emmettbutler avatar May 16 '17 18:05 emmettbutler

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@26ce1c0). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #682   +/-   ##
=========================================
  Coverage          ?   81.25%           
=========================================
  Files             ?       25           
  Lines             ?     3302           
  Branches          ?      485           
=========================================
  Hits              ?     2683           
  Misses            ?      479           
  Partials          ?      140
Impacted Files Coverage Δ
pykafka/connection.py 77.65% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26ce1c0...f273b6a. Read the comment docs.

codecov-io avatar May 16 '17 18:05 codecov-io

See the travis runs on this branch - ssl connections are currently failing with dh key is too small.

emmettbutler avatar May 16 '17 23:05 emmettbutler