compact_str

compact_str copied to clipboard

It would be nice to make such code works: ```rust let s: std::borrow::Cow

Dushistov

WIP: Implement Cow type for CompactString

8

Kijewski

There was a failing test case found when fuzzing! See [Action Run 2941196978](https://github.com/ParkMyCar/compact_str/actions/runs/2941196978)

github-actions[bot]

There was a failing test case found when fuzzing! See [Action Run 2941183389](https://github.com/ParkMyCar/compact_str/actions/runs/2941183389)

github-actions[bot]

Some slightly performance & style updates

3

* In the function `fn as_bytes` in `impl CompactString`, there is an redundant slicing (with a `self.len()` call) which is unnecessary after the update c95edd5. * This crate has documented...

yhx-12243

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start)...

dependabot[bot]

Add support for holding Arc<str> as a new repr?

3

I think it makes sense to support `Arc` in `CompactString` as a new repr, it would then enable O(1) cloning, which is very handy for parser/configuration.

NobodyXu

f64::to_compact_string differs from to_string

1

&1f64.to_string() == "1" &1f64.to_compact_string() == "1.0" I don't have a strong preference either way but this makes post-migration regression testing quite a pain.

turalcar

Improve efficiency of `is_empty`

10

`is_empty` checks both inline length and heap length: https://github.com/ParkMyCar/compact_str/blob/302c595d41373943dc432be2381b8f6a74f0ddf6/compact_str/src/repr/mod.rs#L445-L453 I believe an empty string is always stored inline. Therefore it could be reduced to: ```rs pub fn is_empty(&self) -> bool...

overlookmotel

Shave an instruction off `len()`

10

I believe it's possible to shave an instruction off `len()` (and probably `as_slice()` too) if static string had same discriminant as heap. Static string could instead be represented as a...

overlookmotel