Petros Paraskevopoulos
Petros Paraskevopoulos
Closing this because its associated compile warnings project (paaHJt-3MK-p2) has been marked completed (paaHJt-3MK-p2#comment-6552) for some time already and it is unlikely that more work will be done on that...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @Areeb786123 and thank you so much for offering to contribute! 🥇 Please feel free to start working on this. As such, I'll go ahead and assign this task to...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @Areeb786123 and thank you! 💯 > ...i will complete it as soon as possible There is no rush, please take you time. Actually, it is better if you do...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii and thank you so much for offering to contribute! 🥇 Please feel free to start working on this. As such, I'll go ahead and re-assign this task to...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii and thanks for starting work on that! 🌟 > Did a quite digging, we no longer have ImageSettingDialogFragment,PostSettingsListDialogFragment.java doesn't have findViewById so we can remove it from TODO....
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii ! > Gotcha, Rebasing https://github.com/wordpress-mobile/WordPress-Android/pull/20933 and splitting it into two PR as this has 2 classes covered AddCategoryFragment & PostSettingsInputDialogFragment. 👍 > Would it be okay if I...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii ! > I have rebased and splitted it into Two PR (https://github.com/wordpress-mobile/WordPress-Android/pull/20933 & https://github.com/wordpress-mobile/WordPress-Android/pull/20941) and ready for review. Awesome, thanks, I'll get into reviewing those next week! 🌟...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii and a happy new week to you! ☀️ > If this is no longer used its safe to say both (RoleChangeDialogFragment or RoleSelectDialogFragment) the next step would be...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
> Yes, let me first investigate that real quick, just to verify that both RoleChangeDialogFragment or RoleSelectDialogFragment are not used and then I'll maybe ping you for a removal PR,...
Nullability Annotations to Java Classes - DialogFragment - Replace `findViewById` with `ViewBinding`
👋 @neeldoshii and thanks! > This class WPBottomSheetDialogFragment doesn't have findViewById. I guess you're right, this `FrameLayout bottomSheetLayout = dialog.findViewById(com.google.android.material.R.id.design_bottom_sheet);` usage can be ignored. I've now marked that as done,...