ml-resources-react icon indicating copy to clipboard operation
ml-resources-react copied to clipboard

Published 20 hours ago • verified publisher icon Parasgupta44

Add better stylings / components for this simple React app displaying various resources to learn machine learning.

Open Parasgupta44 opened this issue 4 years ago • 18 comments

Task

Add some components or improve the existing stylings by doing a PR. Please check Readme.md and Contributing.md in the repo's root for more details.

Parasgupta44 avatar Sep 30 '20 06:09 Parasgupta44

Hi @Parasgupta44 , I would like to help on it.

Tailine avatar Sep 30 '20 12:09 Tailine

Hi @Parasgupta44 , I would like to help on it.

Sure, assigned...thanks!

Parasgupta44 avatar Sep 30 '20 12:09 Parasgupta44

how about using material-ui's cards?

CiTRuS93 avatar Sep 30 '20 13:09 CiTRuS93

how about using material-ui's cards?

Yes, these are pretty awesome...would be great if you can come up with something once you get the time! Should I assign this to you as well ?

Parasgupta44 avatar Sep 30 '20 13:09 Parasgupta44

no I won't steal this from @Tailine , just suggesting an idea 😃

CiTRuS93 avatar Sep 30 '20 14:09 CiTRuS93

no I won't steal this from @Tailine , just suggesting an idea 😃

Sure....😄

Parasgupta44 avatar Sep 30 '20 14:09 Parasgupta44

I can help, think rounded corner and animation when hover is better. Also, will add a Hero Section

Jawkx avatar Sep 30 '20 19:09 Jawkx

I can help, think rounded corner and animation when hover is better. Also, will add a Hero Section

Sure...everyone's welcome to contribute. Pretty awesome. Just generate a PR and we'll review and merge.

Parasgupta44 avatar Sep 30 '20 20:09 Parasgupta44

@Parasgupta44 @CiTRuS93 I wasn't thinking about using a component library because the cards are not complicated to do. I will design an example and post here so you guys can take a look.

Tailine avatar Sep 30 '20 22:09 Tailine

@Parasgupta44 @CiTRuS93 I wasn't thinking about using a component library because the cards are not complicated to do. I will design an example and post here so you guys can take a look.

Sure. Also, there were some changes in the design. So, you can also check that out from latest master

Parasgupta44 avatar Oct 01 '20 09:10 Parasgupta44

hey, I did some hover -link preview hoverpreview any thoughts?

CiTRuS93 avatar Oct 01 '20 11:10 CiTRuS93

hey, I did some hover -link preview

This looks great. Gives a more dynamic feel. (which is awesome!!) You can gen a PR if you wanna do it...I'll be happy to incorporate it!!

Edit: Also, can you check how responsive the preview panel is for smaller screens ? That'll be great!

Parasgupta44 avatar Oct 01 '20 11:10 Parasgupta44

@Parasgupta44 @CiTRuS93 I wasn't thinking about using a component library because the cards are not complicated to do. I will design an example and post here so you guys can take a look.

Sure. Also, there were some changes in the design. So, you can also check that out from latest master

@Parasgupta44 No problem. What do you think of this?

card

Tailine avatar Oct 03 '20 23:10 Tailine

This looks good @Tailine

Jawkx avatar Oct 04 '20 02:10 Jawkx

@Parasgupta44 No problem. What do you think of this?

This is pretty good. Also, I was looking, the page is not that responsive for smaller screens....if that works ,,,it'll be awesome !!

Parasgupta44 avatar Oct 04 '20 03:10 Parasgupta44

@Jawkx @Parasgupta44 Thanks guys.

Tailine avatar Oct 04 '20 11:10 Tailine

@Parasgupta44 Could the responsiveness be another issue?

Tailine avatar Oct 04 '20 11:10 Tailine

@Parasgupta44 Could the responsiveness be another issue?

Sure, done. #38

Parasgupta44 avatar Oct 04 '20 14:10 Parasgupta44