ml-resources-react icon indicating copy to clipboard operation
ml-resources-react copied to clipboard

Published 20 hours ago • verified publisher icon Parasgupta44

Added 4 machine learning books

Open Kapilshanbhag09 opened this issue 4 years ago • 5 comments

Kapilshanbhag09 avatar Sep 30 '20 21:09 Kapilshanbhag09

Hi @Kapilshanbhag09 . Thanks for contributing.

  • You have added Books as a standalone React component (?)
  • Do you want to include it somewhere to display on the page ?

Parasgupta44 avatar Sep 30 '20 22:09 Parasgupta44

Hi @Parasgupta44 I had started react js 15 days back and I contributed from whatever I knew. Becuase of which I am not much sure about the React Component. Sorry for that thing.

Its ok if the books lists are at the bottom as your choice.

Kapilshanbhag09 avatar Sep 30 '20 22:09 Kapilshanbhag09

@Kapilshanbhag09 No need to say sorry at all. Everyone's learning here only. One thing you can do is just add those list of books (that you added in ml_books.json) to ml_resources.json in the format given and maybe remove Books.js and Books.css files. You can then generate a new PR with that new commit I can merge it to the master for deploying it.

Parasgupta44 avatar Sep 30 '20 22:09 Parasgupta44

Oh, Ok I will do that

Kapilshanbhag09 avatar Oct 01 '20 05:10 Kapilshanbhag09

I have done it

Kapilshanbhag09 avatar Oct 01 '20 05:10 Kapilshanbhag09