rq-dashboard icon indicating copy to clipboard operation
rq-dashboard copied to clipboard

instance selector shows full redis url with password

Open jtrip opened this issue 5 years ago • 3 comments

Seems like this should be avoided.

Screen Shot 2020-09-01 at 5 59 43 PM

It might also be more helpful if it had a shorter representation. like just host:port

jtrip avatar Sep 01 '20 22:09 jtrip

a possible simple update / workaround:

change line 98 in templates/rq_dashboard/dashboard.js

text: instance.split('@')[1]

Although I think perhaps the password should not be passed in the api results at all. I could take a look at that later maybe.

jtrip avatar Sep 01 '20 22:09 jtrip

Thanks for report, @jtrip! What version if rq-dashboard do you use?

eoranged avatar Sep 02 '20 10:09 eoranged

You're welcome :) thanks for the consideration.

This is on VERSION = '0.6.1'

jtrip avatar Sep 02 '20 15:09 jtrip