Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Kills `/obj/item/melee`

Open kyunkyunkyun opened this issue 3 weeks ago • 0 comments

What Does This PR Do

Typepath only used for 4 pre-declared vars (icon, left/righthand files, needs_permit), 2 captain's suit storages and /obj/machinery/transformer/xray (not sure if this thing is used) should probably not exist. So this PR kills it

  • /obj/machinery/transformer/xray now triggers alarm on any item that has needs_permit instead of only subtypes of /melee items
  • captain's carapace/magnate no longer can hold subtypes of /melee, i replaced it with only his saber. If captain should retain its ability to hold most of /melee items, i can create a global list with their subtypes to keep the old behaviour
  • manually moved 4 vars from /melee path to its subtypes

I regex replaced it, made an updatepaths script, DB python script. no other changes i believe.. oh and i updated .md doc

python script will update 3 tables in DB - feedback, json_datum_saves and characters. they all can be found in the script itself under tables list. if there is any other tables that should be updated - lmk

Why It's Good For The Game

It's like obj/item/device but lives longer People also use this and later redeclare icon, left/righthand file vars.. so.. yeah.. there is not much sense in keeping this If someone wants to hold most (not even all since some melee items never used this typepath) of melee items, we can create a global list with them

Makes sense to half of headcoders (i know, crazy stats i gathered), lewcc long time ago asked me to stop using this typepath in my pr, so it's 99.9% wanted change to get rid of this

Testing

It compiles. python script, however, should be checked, but surely it's ok and i don't have to make a db test for this, right? right???

Declaration

  • [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
image

kyunkyunkyun avatar Dec 09 '25 05:12 kyunkyunkyun