ParadiseSS13
Fix issue with cooking recipes requiring reagents
What Does This PR Do
This PR fixes issues with cooking where multiple recipes with varying amounts of the same reagent ID at the same step may cause one recipe to no longer be considered valid. The issue stems from not properly handling cases where one single action may be a valid step in two recipes, but where only one step is completed (e.g. one recipe requires 5u milk, one requires 10u, and the player adds 5u to the container). This cleans up a bit of the tracker code, pulling step attempt info into a datum that we can still toss away at the end of the proc.
Why It's Good For The Game
Bugfix, more reliable cooking behavior, hopefully.
Testing
In progress.
- [x] Banana bread / Banarnar bread recipe issue
- [x] Autochef interactions
Declaration
- [X] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
:cl: fix: Banana-nut bread's recipe can now be followed properly. /:cl:
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.
Kitchen machinery when upgraded does not produce more than one food, here is an example of an oven that was upgraded but producing 1 bread
DEBUG: More than one valid recipe completion at the same step, this shouldn't happen. Valid recipes: /datum/cooking/recipe/carrotfries, /datum/cooking/recipe/deep_fried_anything
Edit: Unrelated issue, not relevant
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.