Make multitile airlocks/poddoors non directional
What Does This PR Do
Makes multitile airlocks/poddoors non directional once again
Changes their icons to match direction
Does cleanup that #29382 was supposed to do + a bit more
Removes MAPPING_DIRECTIONAL_HELPERS_MULTITILE - it was made only for directional airlocks
Adds rule allowed_values_by_var to linter to prevent people placing these airlocks with dirs of 1 or 8 - they look kinda the same but will have an offset after initialization
Fixes that filler wouldn't move with the airlock on shuttle movement (no one noticed that issue cos we don't have opaque airlocks on shuttles)
Fixes that you couldn't push multitile airlock's assembly to WEST/SOUTH (you still can't pull it to north/east due to some pull code)
Why It's Good For The Game
We always had them in 2 dirs - 1 and 4, so we kinda go back to this. Adding new rule to linter is required cos previously they were hardcoded to 2 dirs so it wouldn't matter which direction you put in SDMM, now they may be rotated to all 4 No need to create lots of directional subtypes - they work all the same and we have like ~100 less subtypes in code And fixes
And i'm kinda sorry for messing with this code that much, lol. But it's on your conscience as well since you are those who let #28928 go through! just kidding
Testing
MDB for map changes (should be no visible changes) Ensured that they work properly on shuttle movement/rotate and alongside mapmanip orientation Failed a linter when i put an airlock with a dir of 1 on map - rule is working
Declaration
- [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
:cl: fix: Airlock fillers now properly update their location when they move. fix: You can now push multitile airlock's assembly to west or south. /:cl:
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.