ParadiseSS13
Bumps max client fps from 120 (125) to 1000
What Does This PR Do
Converts available fps options to list, rather than just a number. Byond doesn't accept some values like 60, always rounds up them to the available ones (i. e. 60 -> 63, 120 -> 125, 501 -> 1000). According to Lummox's comment on client fps, i'm also keeping only divisors of 1000 for available options - they work.. better.
I'm also bumping default fps to 100 from 67 since the removal of 60 as an option
#17564 made clientfps 63 by default, which then is always converted by byond into 67, means there is no reason to keep already converted value.
Removes some outdated lines about 511 - you need at least 513 (according to Toastical's words) as a client
Why It's Good For The Game
Max fps was set to 120 by Aylongo back in #23891. Previously there was no limit afaik. Capping max fps to 120 looks like an oversight. Showing players what their actual fps cap will be is good, i suppose
Testing
My clientfps and client.fps are updated correctly - i got what i've picked
Declaration
- [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
:cl: tweak: Max client fps is now 1000. Available fps options are now listed since BYOND takes them weirdly. tweak: Default FPS is now 100. /:cl:
No reasons to set it this high tbh. 100 would be more optimal than 120 though. If you are raising it, allow the 1000 then(it was stated by Lummox that divisors of 1 work better as tick_lag). Also would make sense to replace the number input with selection of actual available fps so people wont get confused
I think slider would be the best, but I dont think that we have such a tgui component
might be worth setting default clientfps to 100 rather than 60, according to Lummox's words that divisors of 1000 work better
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
If I currently have my FPS set to 60 and then I change it to 100, will there be any noticeable change?
if your monitor has more than 60hz refresh rate - yes, the game will be more smooth. also your cpu and gpu will start rendering more frames which might lead to higher load % but i don't think this will be an issue with SS13... it's not unreal engine to be a big issue
drafting cos there is some issues about the code + have to apply the review changes