ParadiseSS13
Event system refactor and changes
What Does This PR Do
Refactors the event system, moving some weight calculations from event_meta to event, which should allow more flexibility in calculating the weights of each events. The staffing pool for changing event weights is now affected by active events and antags Adds a new event level: Disaster, which contains potentially round ending events like blob, xeno and terror spiders.
Why It's Good For The Game
Event timing is currently very awkward and there are limited ways to manage if and how frequently certain events should be happening. This refactor aims to allow for more flexibility in that regard.
Images of changes
Testing
Declaration
- [ ] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
:cl: tweak: Events now have 4 levels rather than 3 tweak: The staffing pool for changing event weights is now affected by active events and antags tweak: Events now handle weight calculations instead of meta events /:cl:
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.
This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.
Unsure if this is fitting for this PR or if it would be best to do it separately, but I believe making it so traders being denied can't reroll into nothing would be a nice change, makes no sense that it needs to roll the chance again after it already succeeded.
Paraphrasing from deadchat, so may not be the best source:
From what I can tell the normal disasters combined have a weight of 270 and nothing has a weight of 5730. This is less than a 5% chance for any disaster to roll
I personally haven't seen ANY of the biohazards roll while this has been testmerged. I've seen plenty of the other events, but not a single biohazard of any type.
I've also heard that Disaster apparently rolls every 40-50 minutes, assuming the best RNG this will roll 3 times per round, I think it'd be fair to up it considerably or lower the nothing weight.
It appears the notification for the Meteor event finishing can play before it fully ends.
Additionally, the event notification in the top right corner never clears after the event ends. Let me know if these aren't this PR's doing because otherwise I can issue report them
Appears the meaty ore event has been happening on occasion with no announcement beforehand as it used to have, seen it happen a couple of times now I believe.
Appears the meaty ore event has been happening on occasion with no announcement beforehand as it used to have, seen it happen a couple of times now I believe.
Tested on my end and it seems to work fine. Do note that there is a 16% chance to do a biological entities announcement instead of meaty ores
in round 46062 there was (to my knowledge) a tot a cling a blob a stealth lethal virus a slaughter demon and meteors. All with around ~30 crew playing. This is not good for lowpop, at all.
to add more info on Seren's earlier comment, the blob, lethal stealth virus, meteors and slaughter demon all happened during the last 30 minutes of the shift, one after the other/all at once. It was hard to tell.
in round 46062 there was (to my knowledge) a tot a cling a blob a stealth lethal virus a slaughter demon and meteors. All with around ~30 crew playing. This is not good for lowpop, at all.
There were some bugs in demon events requirements and costs as well as disaster lateroll prevention. These should be fixed now.
Appendicitis appears to be occurring at a lot higher rate than before, I've had and seen others have it rather often mostly on lowpop rounds.
