Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

New Xenomorph Organ Sprites

Open ajc007007 opened this issue 7 months ago • 7 comments

What Does This PR Do

Adds new textures for certain xenos organs, including hijacked organs.

Why It's Good For The Game

To be able to distinguish xeno organs from eachother, and to know at a glance if an organ is hijacked or not

Images of changes

image_2025-05-17_151105079 image_2025-05-17_151126195

Testing

I unfortunately did not test the different sprites between the unhijacked and hijacked organs. (I have no idea how to code, nor how to test)

Declaration

  • [ ] I confirm that I either do not require [pre-approval] for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

:cl:

ajc007007 avatar May 17 '25 19:05 ajc007007

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

ParadiseSS13-Bot avatar May 17 '25 19:05 ParadiseSS13-Bot

I like the sprites a lot !

Two things though:

  • The egg sac organ does not have an hijacked sprite, is it intentional or did you forget to include it in the PR's file ?
  • The hijacked xenomorph liver/resin spiner has a few too many white pixels that cover parts of the fleshy mass, it might be intended but I prefer to ask if it is ?

leboucliervert avatar May 17 '25 20:05 leboucliervert

I like the sprites a lot !

Two things though:

  • The egg sac organ does not have an hijacked sprite, is it intentional or did you forget to include it in the PR's file ?
  • The hijacked xenomorph liver/resin spiner has a few too many white pixels that cover parts of the fleshy mass, it might be intended but I prefer to ask if it is ?

Thanks for the feedback!

To answer your two questions

  1. I didn't get around to doing the hijacked egg sac (But maybe I will)
  2. I think that's a visual bug. It's not supposed to look like that resin_hijacked

ajc007007 avatar May 17 '25 21:05 ajc007007

It probably was my computer playing tricks then, the sprite in your answer does not have the white pixels I spoke of earlier 👍

leboucliervert avatar May 17 '25 21:05 leboucliervert

It probably was my computer playing tricks then, the sprite in your answer does not have the white pixels I spoke of earlier 👍

image eggsac_Hijacked Also

ajc007007 avatar May 17 '25 21:05 ajc007007

just adding new icons won't make them appear in game, you have to add something like this

/obj/item/organ/internal/alien/update_icon_state()
	. = ..()
	icon_state = initial(icon_state) + (hijacked ? "_hijacked" : "")

and add an update_icon() into attackby__legacy__attackchain()

so it will look like this

image

you can find this code in xenos.dm

kyunkyunkyun avatar Jun 02 '25 19:06 kyunkyunkyun

Account linked. Hold removed.

Burzah avatar Jun 18 '25 20:06 Burzah

Closing this PR for now. It has sprite team approval, but merge conflicts have not be settled. This PR can be reopened after conflicts are dealt with. Please contact the sprite team or ask in coding chat if you need assistance with this. Thank you.

Burzah avatar Jul 15 '25 20:07 Burzah

just adding new icons won't make them appear in game, you have to add something like this

/obj/item/organ/internal/alien/update_icon_state()
	. = ..()
	icon_state = initial(icon_state) + (hijacked ? "_hijacked" : "")

and add an update_icon() into attackby__legacy__attackchain()

so it will look like this

image

you can find this code in xenos.dm

I'll figure this out. Not great at coding, nor can I wrap my dome around it, but I can try.

ajc007007 avatar Nov 03 '25 20:11 ajc007007