CSI Eridani: Detective content update

[silverplatedelta]

What Does This PR Do

This PR reworks the detective role by porting ss220's content, which itself was ported from bay station.

Reworking the Office

The Detective office will be divided into two sections.

• General office setting, for speaking with witnesses and administrative work.
• Forensics lab for performing analysis in a scientific manner on evidence.

Detective Gear

The gear issued to a detective should be augmented and changed to better reflect with the intended vision.

• Scanner has been replaced with specialist gear, which is outlined below.

Death to the scanner, or how I learned to love cassette futurism

I removed the forensic scanner (it will remain in code). Being able to scan any item for blood/prints/fibers/chems from anywhere on screen is a TAD strong, and makes detective work trivially easy. In the new detective office there will be a number of evidence collection kits (one per det locker, plus they can be easily ordered from cargo). Each of these kits will contain: Swab kits, evidence bags, fingerprint powder, a fiber collection kit, and figerprint pads.

How does this change evidence collection?

Players can be swabbed in the cheek to get a DNA sample, the hand (or gloves) to check for gunshot residue (Identifies caliber of the weapon), or in general to swab for blood.

Blood on the ground can be swabbed.

Items and objects can generate finerprint cards with the fingerprinting kit, or the fiber kit to pull fibers off.

all evidence items are physical things that need transported back to the detective lab.

DNA swabs and blood samples are input to the DNA analyzer machine, and a report is automatically generated along with an automatic report number attached.

GS residue, prints, and fibers can be ran through the microscope to the same effect.

Detectives can then combine the evidence they collect with things like medical records to identify a perp.

The DNA analyzer can be empited with alt click, and used by clicking on it with an item, then clicking on the device again.

Why It's Good For The Game

Detective has suffered from a lack of content as a result of what the role was intended to be when it was converted to a more hands on security position. These proposed changed have been designed to increase RP and actual investigation.

Testing

Spawn as det. do crime. investigate crime. profit.

---

Declaration

• [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

  ---

Changelog

:cl: silverplate, Aylong add: Added the DNA analyzer, microscope, and crime scene kit del: removed the forensic scanner tweak: added new forensic lab area to the detective office /:cl:

[Danchi299]

I removed the forensic scanner (it will remain in code). Being able to scan any item for blood/prints/fibers/chems from anywhere on screen is a TAD strong.

Sounds like a Research / Cargo item, maybe tuned down to multi-use and/or remote swab. Or Detective multi-tool in general with Ultraviolet Lights attached.

[silverplatedelta]

PR is feature complete, just need to get the mapping to behave.

[spacegeese]

will there be fingerprint records for each crewmate or will you have to go around and find them yourself?

[silverplatedelta]

will there be fingerprint records for each crewmate or will you have to go around and find them yourself?

Fingerprint records already exist inside the medical record console.

[SynthTwo]

!wiki_label

[silverplatedelta]

Just a quick update on this: I don't have access to my development environment until Monday the 30th. That week ill make sure this gets done. Its feature complete, just need to de conflict the maps and update the attack chain!

[github-actions[bot]]

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

[github-actions[bot]]

This pull request has not received any updates since being marked stale, and as such is now being automatically closed. Please feel free to re-open this pull request or open a new one once you have new updates.

[silverplatedelta]

Hey people! I managed to figure out most of the outstanding issues here.

As of this time, I need to re-address the old reviews, and figure out why the attack chain is acting up for putting swabs into the DNA scanner. Everything else is fully functional as of this time. Mapping is also complete!

Finally, I need to add a way to search medical records by DNA and fingerprint strings prior to merge.

I need some pointers with these items, so Ive gone ahead and re-opened the PR.

[silverplatedelta]

Life again came in with a steel chair, will try to finish this in a month or two.

[silverplatedelta]

While life continues to throw cinder blocks at my face, I will re-open this for review, hopefully when I get more free time it will be TM ready.

[Dafrek]

These changes are rather neat, especially being able to now use forensics to find out if someone fired a gun. However going from an infinite use scanner to a 7 use kit that needs to be re ordered from cargo is a rather large downgrade, especially when you consider how much forensics is sometimes needed.

An example of this would be two traitors both buying surplus crates, one of them getting caught and the detective now having to go through upwards of 20 items to try to see if they can find prints or fibers of the other traitor. Keeping some sort of way to go through all these items would be nice.

[silverplatedelta]

Thanks for the feedback! The only item that's limited are the single use blood/DNA/GSR swabs. There are 3 boxes for a total of 18 available roundstart currently. Fibers and print kits have infinite uses atm.

While 18 isnt not a ton, in the few rounds I observed I only say about 10 be used.

Again, thank you for the feedback, and I will be monitoring this issue to see if additional items need to spawn in the detdrobe/locker!

[Monkeke2]

Really like seeing detective get some work, but I highly doubt this will change how much detective work is actually needed. I feel like most of the time detective will still be a secoff with a revolver. Hopefully it will be more useful, especially with the GS residue.

[github-actions[bot]]

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

[silverplatedelta]

PR is on hold until TGUI6 and server is on 5.16

[silverplatedelta]

Work is resuming on this PR.

Changes in the upcoming commit include: Samples can now be printed at an autolathe GSR actually works.

[Burzah]

!merge_upstream

[paradisess13[bot]]

GitHub Actions can not push to this branch as workflow files have been changed since your branch was last updated. Please update your branch past https://github.com/ParadiseSS13/Paradise/commit/16c4a350fc99c8d632d03886ba91ab21629eed47 before using this command again.