Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Makes Disarmed Pizzabombs closeable, refactors their code

Open Contrabang opened this issue 4 months ago • 1 comments

What Does This PR Do

Refactors 85% of pizza bomb code. Fixes #27004. Pizzas with no tags will no longer have the box_tag overlay. Pizza bombs boxes can now be toggled closed when counting down to exploding and after they're disarmed.

Why It's Good For The Game

Gets rid of a lot of bad code. It also adds parity with how normal pizza boxes work given that you can now close the boxes.

Testing

Normal pizzas seemed fine, and empty pizza boxes had no tags. Went through the full pizza bomb detonation process. Then sucessfully disarming one, then failing to disarm one and exploding one. Was also able to deconstruct the disarmed one.


Declaration

  • [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image (Changed to be just disarmed pizza bombs)

Changelog

:cl: tweak: Disarmed Pizza bombs can now be closed once opened. fix: Pressing Cancel on a pizza bomb time setting will properly cancel arming it and close the box. fix: Pizzas with no tags will no longer have the box_tag overlay. /:cl:

Contrabang avatar Oct 07 '24 04:10 Contrabang