Fix for #25458

[PGrayCS]

What Does This PR Do

Changes Made: Modified the rename function in photo object: Added scribble = n_name to ensure the scribble is set when renaming a photo. Added max_length = 128 to the input to prevent excessively long labels. Updated the show function: Separated the scribble HTML generation for better readability and consistency. Ensured the scribble is always displayed, regardless of photo size.

Why It's Good For The Game

Provides a fix for #25458 Consistency Across Photo Sizes: This fix ensures that writing on the back of photos works consistently for all photo resolutions, including the 7x7 size. Players can now expect the same behavior regardless of the camera settings they use. Improved User Experience: Players will no longer face the frustration of being unable to add or view text on larger photos. This enhances the overall photography feature in the game. 3. Bug Resolution: Addresses a specific bug that was affecting player enjoyment, particularly for those exploring photography as a new in-game hobby. Encourages Feature Usage: With the fix in place, players are more likely to use and enjoy the photo labeling feature across all photo sizes, potentially increasing engagement with the photography aspect of the game. Code Clarity: The changes improve code readability and maintainability, making it easier for future developers to understand and modify the photo functionality if needed. 6. Prevents Potential Exploits: By adding a maximum length to the input, it prevents potential issues or exploits related to extremely long photo labels. 7. Maintains Immersion: Ensuring that all game features work as expected helps maintain player immersion and the overall quality of the game experience. These changes contribute to a more polished and consistent gameplay experience, addressing a specific user-reported issue while potentially improving the system for all players engaging with the photography feature.

Images of changes

Testing

---

Declaration

• [ ] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

  ---

Changelog

:cl:

fix: Fixed a few things

/:cl: