Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Getting rid of generic first aid kits in mapping

Open kyunkyunkyun opened this issue 1 year ago • 0 comments

What Does This PR Do

Makes /obj/item/storage/firstaid generic Removes all /obj/item/storage/firstaid from dmm files, replacing them with /obj/item/storage/firstaid/regular or /obj/item/storage/firstaid/regular/empty if they are in maintenance/robotics area Also moves regular's code a bit higher so it's more obvious which one to spawn instead of generic /obj/item/storage/firstaid/doctor is now /obj/item/storage/firstaid/regular/doctor This also fixes empty first aid kits in medical storage, some escape shuttles, some ruins and admin areas. Fixes /obj/item/storage/firstaid/surgery missing inhand sprite.

Why It's Good For The Game

Mappers like to put /obj/item/storage/firstaid somewhere, thinking it has some medicine inside. It's not Will prevent them from using this type of kit and force them to use empty type

Testing

Checked all of them on a local server: Empty are empty, regular are full packaged. Kits spawn properly on shuttles, maps, ruins etc. Made sure every single first aid has it's icon state, in hand sprite.


Declaration

  • [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

:cl: fix: Fixed empty first aid kits on stations, shuttles, ruins. Field surgery kit is now can be seen in your hands. /:cl:

kyunkyunkyun avatar Sep 30 '24 15:09 kyunkyunkyun