Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

[REFACTOR] Consolidates SLOT_FLAG and SLOT_HUD into one ITEM_SLOT flag

Open Adrer opened this issue 5 months ago • 2 comments

What Does This PR Do

THIS SHOULD PROBABLY BE TESTMERGED BEFORE BEING FULLY MERGED

This PR consolidates SLOT_FLAG and SLOT_HUD into one ITEM_SLOT flag, this should make it easier to compare and check inventory flags without needing to perform weird conversions between the two.

[!NOTE] In doing this I accidentally fixed the "offear" feature, which would block your second ear slot if you were wearing a bowman headset. For the time being, code relating to this has been commented out. Fixing/removing this will be done in a PR seperate from this one.

Why It's Good For The Game

These flags perform literally the same job, there is no reason for them to be seperated like this. This should make some things at least somewhat easier to do.

Testing

I can equip stuff fine I can remove stuff just fine Stripping people and putting stuff on them seems to work still As far as I can tell nothing is broken but this should still be testmerged for a little bit just in case.


Declaration

  • [x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

Adrer avatar Sep 10 '24 14:09 Adrer