Paradise
Paradise copied to clipboard
Less scuffed Tajaran veils
God, please, do not explode, I'm not even sure how did this commit make so many changes to paradise.dme.
What Does This PR Do
- Moves all Tajaran veils code to a separate file for the sake of sanity and giving them a unique feature.
- Adds welding-level flash protection to a turned off veil (this is largely due to me suffering a Mandela effect and strongly believing this was an intended mechanic that was accidentally removed when, in fact, it was explicitly removed).
- Removes drask from the list of species using special veil sprites because their eyes.dmi does not even have veil sprites.
- Adds the aforementioned feature, a third "mode" of veils: colorblindness-correcting mode which overrides all types of colourblindness.
- Makes industrial (engineering) and khaki (cargo) veils into fully functional meson scanners. Makes hi-tech (science) veil into fully functional science goggles. Adds shaded variations of all veils, which provide same flash protection as sunglasses.
- Makes all veils craftable out of a basic veil and a type of eyewear you want it to mimic (diagHUDs, skillHUDs and janiHUDs not included). Makes specialised veils de-craftable.
- Removes all but the basic veil from the loadout menu, given how this would allow people to spawn with specialised eyewear normally not available on-spawn.
- Adds text flavour that was provided by the lore team based on their plans for Tajara and the feature mentioned earlier.
Additionally, if design team approves any of this, I'll plan to push for one more change - restricting these veils exclusively to Tajara. Vox have multiple species-unique items. Similarly, plasmamen have received recently a unique loadout item only they can use. Traitor uplink has a handful of species-restricted items, too. The previous attempt at such a restriction of veils was denied due to concerns that Tajaran security officers would have access to a HUD that effectively cannot be stolen. By making security HUD veils de-craftable, this would be far less of an issue and the idea could be reconsidered.
The problem? This code, admittedly, does cheat a little. If the colourblindness correction thing (which is the primary issue that somewhat breaks the OOP approach here and created a tiny bit of duplicate code) is a problem, I'm more than willing to just scratch the whole mechanic for the sake of at least giving functionality of common utility eyewear to these veils (and pushing for a species restriction again).
Why It's Good For The Game
The veils were added about 7 years ago and, in that period of time, were touched only once. They are pretty miserable items that were tackled onto random glasses to justify adding sprites that no longer really hold up.
This attempts to make them better. For one, Tajara no longer have to pick between genuinely useful glasses like mesons and their dedicated flavour item. Additionally, it actually mechanically compliments Tajara. They have a unique a colourblindness matrix to encourage picking it as a disability and veils they invented to correct it.
The welding protection was added due to a misconception (as well as belief that regular blindfolds are in the loadout), so I'll gladly lower or remove it if it's deemed too problematic. And interesting alternative, however, could be making working veils lower flash protection. Should the item ever become Tajaran-exclusive, it would serve as an additional opt-in malus. Not sure how shaded veils would work in that case, though.
Now, I'm not going to lie, it was pointed out repeatedly: Prescription veils in this case allow you to get -20 instability points without any actual drawbacks. This can very reasonably cause problems, yes. However, if this is a problem that would warrant rejection, I suggest a different solution: I add an emp_act() to the veils. This would shut them off and render useless until repaired, likely with something like do_after() with a screwdriver. A more severe consequence could be considered, too.
Testing
Spawned in, crafted all types of veils, wore them, correctly switched between all three modes, de-crafted them.
Changelog
:cl: tweak: All Tajaran veils were renamed and reworked. tweak: Industrial and khaki veils are functionally meson scanners. tweak: Hi-tech veils are functionally science goggles. tweak: All Tajaran veils have shaded versions, which add sunglasses-like flash protection. tweak: Removed all but one Tajaran veil type from the character loadout menu. tweak: All Tajaran veils can now be crafted using the loadout veil. tweak: Tajaran veils now offer welding protection when turned off. add: Tajaran veils now have an additional mode: colourblindness correction. /:cl: