Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Converted supply shuttle to a signal-based system.

Open FunnyMan3595 opened this issue 11 months ago • 1 comments

What Does This PR Do

Refactors the entire system for sending stuff to CC on the cargo shuttle to use a signal-based approach, which makes things like #24599 easier.

It's not a pure refactor, however, as there are quite a few functionality changes; see the changelog for details.

Why It's Good For The Game

Modular, extensible code is good. CC should behave a bit more sensibly with what you send them now.

Images of changes

image image

Testing

Sent a shuttle with all the stuff that's worth money or loses you money, see images. Sent a shuttle with an empty mail crate and a crate with a pen in it. Got the pen back. Tried to send the NAD, failed. Sent wrong virus samples and a vial lockbox, no complaints about junk items. Send a virus sample with Virology Goals' checking turned off, completed those goals.

Changelog

:cl: add: Items on the supply shuttle but not in crates will now be sold, but CC will charge you a fee for not securing your cargo. add: CC will charge you a cleaning fee if there are messes on the supply shuttle. add: CC will charge you a nuisance fee if you send them stuff that they don't care about. On the upside(?), they'll send it back to you. add: All mechs can now be sold to CC for a flat rate. tweak: CC has learned that containers can fit in crates, and will find your valuable stuff, even if it's nested deeply. Plasma in a backpack is now acceptable. tweak: CC will now pay for the potency of the first seed of each type. tweak: There's a message when CC buys alien organs now. tweak: There's a message when you send stuff that CC almost wants now, e.g. blank disks. tweak: Empty mail crates can now be sent back to CC like other crates. tweak: CC will now indicate which account they paid credits into or charged a fine from. tweak: When the shuttle is blocked from leaving the station, the error message will now indicate the specific reason and item, rather than a generic list of things that are not allowed. fix: Stuff sent from CC on the supply shuttle will no longer be sold before it can reach the station. tweak: The shuttle will refuse to send if it contains a locked lockbox, but the lockbox doesn't contain a goal item. fix: Virology goal error messages will no longer complain about a virus sample if a different goal wanted it. /:cl:

FunnyMan3595 avatar Mar 14 '24 16:03 FunnyMan3595