Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Ports TG bamboo and Punji Sticks

Open chuga-git opened this issue 11 months ago • 4 comments

What Does This PR Do

Ports https://github.com/tgstation/tgstation/pull/64027 (mostly)

  • Adds bamboo as a growable plant, available in the seed vendor
    • Updates old bamboo harvest sprite
  • Adds craftable bamboo items and structures
    • bamboo and tatami mats
    • bamboo stools
    • bamboo benches
    • bamboo walls
  • Adds craftable bamboo blow gun
    • Deals 20 stamina and 20 oxygen damage to the user per use
  • Adds punji sticks, craftable using bamboo planks
    • Goes through shoes, inflicts a 6 second weaken when stepped on, which deals between 20 and 30 brute damage
    • Does not affect modsuit wearers (or other types of thick clothing)
  • Adds an adjustable weaken_duration parameter to the caltrop component to control stun time (default is 6 SECONDS)

Why It's Good For The Game

They will learn to fear the maintenance jungle. Also, fluff items are pretty cool.

Images of changes

image

Testing

(botany stuff)

  • [x] Plant
    • [x] seed sprite
      • [x] Fix growth sprite negative z offset
    • [x] plant grows properly
    • [x] plant harvests properly
    • [x] plant sprites
    • [x] logs work properly
  • [x] Logs and sheets merge and craft properly

(craftables)

  • [x] Floor tiles
    • [x] Fix weird stack merging issues with tile stacks
    • [x] Bamboo mat placement and sprite rotation
    • [x] Tatami mats
    • [x] Tile smoothing
  • [x] Wall and false wall sprites & smoothing
  • [x] Benches
  • [x] Stools (should be fixed)
  • [x] Punji sticks
    • [x] Sprites and crafting
    • [x] Doesn't go through modsuits (or similar puncture immune clothing)
    • [x] Locker shenanigans (this can't be avoided without a full refactor of Crossed() as far as I can see)
    • [x] Placement shenanigans
  • [x] Spear
  • [x] Blowgun
  • [x] Unfuck caltrop component because something has gone terribly wrong

Changelog

:cl: add: Bamboo: a growable plant available in the hydroponics seed vendor, along with craftable walls, mats, stools, and benches. add: Punji sticks: a deadly trap that can penetrate through shoes, craftable using bamboo. add: Blowgun: a makeshift bamboo syringe gun that exhausts its user after too much use. add: Bamboo spear: it's a spear made out of bamboo. /:cl:

chuga-git avatar Mar 07 '24 22:03 chuga-git

Adds craftable bamboo blow gun

* Deals 20 stamina and 20 oxygen damage per use

* Details probably subject to change

good lord, craftable 20 stam gun? cant wait for people to craft 50 of them in a boh and rapid fire them...

1080pCat avatar Mar 08 '24 10:03 1080pCat

Adds craftable bamboo blow gun

* Deals 20 stamina and 20 oxygen damage per use

* Details probably subject to change

good lord, craftable 20 stam gun? cant wait for people to craft 50 of them in a boh and rapid fire them...

My bad, that was supposed to read "to the user". The description has been fixed.

chuga-git avatar Mar 08 '24 16:03 chuga-git

I've got a couple concerns here:

  1. I'm not a fan of the sprites, and I've heard similar opinions from others. Please speak with our sprite team in Discord to figure out how to adjust them (and see if you can get help, if needed).
  2. The blowgun and punji sticks, while neat, are adding yet more combat capabilities to Botany, which they really don't need right now.

FunnyMan3595 avatar Mar 20 '24 19:03 FunnyMan3595

I've got a couple concerns here:

1. I'm not a fan of the sprites, and I've heard similar opinions from others. Please speak with our sprite team in Discord to figure out how to adjust them (and see if you can get help, if needed).

2. The blowgun and punji sticks, while neat, are adding yet more combat capabilities to Botany, which they really don't need right now.

Hi, thanks for the reply.

  1. Ramon and Denthamos brought up sprite concerns earlier, and indicated his willingness to re-sprite some of the floor tiles. Unfortunately, that did not include the walls, so I will have to axe them from this PR until another spriter is willing to pick up the torch to 3/4th-ize them.
  2. I saw no issue with the blowgun because of its relative uselessness in the face of other, more easily available analogs, like improvised shotguns. Punji sticks are decently powerful in theory, but they're also pretty easy to spot with a flashlight and easy to destroy with whatever's on hand. Any other kind of botany death plant would be a more worthwhile time investment if you want to maximize carnage.

chuga-git avatar Mar 20 '24 19:03 chuga-git