Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Ports action button refactor from /tg/

Open lewcc opened this issue 11 months ago • 11 comments

What Does This PR Do

Ports changes implemented in https://github.com/tgstation/tgstation/pull/65180. See the PR for details on the changes and the rationale behind them, I pretty much brought this over wholesale, save for the preference saving for positions. I didn't really want to futz with that, at least not yet.

The big changes: image

  • Meet the action palette, your new best friend.
    • Hover over the palette (the button that looks like [....]) to see the options.
    • Instead of having the binary choice of either seeing all of your actions or none of them, you can now hide some actions inside the palette.
    • You can click the palette to un-hide those hidden buttons, or just click anywhere else, and it'll hide them again.
    • You can drag buttons into them and out of them. It's pretty nice. Cheers, lemons.
  • Action button code is a lot nicer
    • If you're not a coder, you probably won't care about this, but...
    • action buttons are now created dynamically per hud (read: per user seeing them).
    • this doesn't do much yet, but will be very useful down the line (wink, wink)

I really didn't want to do this originally, but https://github.com/ParadiseSS13/Paradise/pull/24382 drove me crazy enough that I figured I had to.

Why It's Good For The Game

This should make action button usage a LOT easier, and helps with things down the line. It's some QoL that's not that hard to implement, and vastly overdue.

Images of changes

https://github.com/ParadiseSS13/Paradise/assets/89928798/7d47fe0b-5b13-48b6-95fa-482b9a2fbc0d

Testing

Also pending! See video, however.

Changelog

:cl: add: Meet the action palette! Hover over the bar in the top left with your mouse to see options, and try dragging action buttons around. tweak: Dragging buttons around is much cleaner, and provides a lot more feedback. /:cl:

lewcc avatar Mar 07 '24 02:03 lewcc