Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Removes Advanced Reagent Scanner from Service & Medical cyborgs

Open CRUNCH-Borg opened this issue 1 year ago • 8 comments

What Does This PR Do

Removes the Advanced Reagent Scanner from the Service and Medical cyborg modules.

Why It's Good For The Game

Service and Medical already have see_reagents = TRUE, and thus can see the exact chemical contents of beakers by simply examining them. The reagent scanner takes up a slot in the inventory that it doesn't have to.

Testing

Be borg. Didn't have scanner.

Changelog

:cl: del: Medical and Service borgs don't have an Adv. Reagent scanner no more. /:cl:

CRUNCH-Borg avatar Mar 05 '24 21:03 CRUNCH-Borg

can see the exact chemical contents of anything by simply examining them

Are you sure about that? image

FunnyMan3595 avatar Mar 05 '24 22:03 FunnyMan3595

can see the exact chemical contents of anything by simply examining them

Are you sure about that?

Fair, but neither borg type has much business looking at pills anyway, considering they cannot handle them.

CRUNCH-Borg avatar Mar 05 '24 22:03 CRUNCH-Borg

To be honest, I don't believe Borgs need to know the exact units in something, just the different reagents inside, I believe this to be a good change, less stuff in an already full toolbar is nothing but positive in that aspect, while they do lose the ability to know the exact amount of units, that isn't too important for a borg, so it is a little down side, it is a pretty ignorable down side.

Plus, they can see the percentage of the different reagents still at least.

Stoniest avatar Mar 06 '24 02:03 Stoniest

Just want to confirm, can the medical borg see the contents of a beaker with this pr

Oyu07 avatar Mar 06 '24 03:03 Oyu07

Just want to confirm, can the medical borg see the contents of a beaker with this pr Yes image

CRUNCH-Borg avatar Mar 06 '24 03:03 CRUNCH-Borg

can see the exact chemical contents of anything by simply examining them

Are you sure about that?

As it turns out, the advanced reagent scanner only gives %amounts for pills, cigs, and food items too! There's ACTUALLY no loss of functionality vs just having reagent vision.

CRUNCH-Borg avatar Mar 07 '24 14:03 CRUNCH-Borg

can see the exact chemical contents of anything by simply examining them

Are you sure about that?

As it turns out, the advanced reagent scanner only gives %amounts for pills, cigs, and food items too! There's ACTUALLY no loss of functionality vs just having reagent vision.

Reagent vision doesn't even show that; the output in my image was from using the advanced reagent scanner after examining each.

FunnyMan3595 avatar Mar 07 '24 14:03 FunnyMan3595

I'm really not fond of losing the ability for service borgs to see what's in food and medborgs to see what's in pills/patches, so I'm against removing this until/unless that gets addressed.

FunnyMan3595 avatar Mar 22 '24 16:03 FunnyMan3595

I'm really not fond of losing the ability for service borgs to see what's in food and medborgs to see what's in pills/patches, so I'm against removing this until/unless that gets addressed.

I'll see if I can make reagent vision do the scanner stuff.

CRUNCH-Borg avatar Apr 04 '24 00:04 CRUNCH-Borg

I'm really not fond of losing the ability for service borgs to see what's in food and medborgs to see what's in pills/patches, so I'm against removing this until/unless that gets addressed.

Ye have asked and ye have recieved! image

CRUNCH-Borg avatar Apr 06 '24 23:04 CRUNCH-Borg

Design LGTM now.

FunnyMan3595 avatar Apr 06 '24 23:04 FunnyMan3595