Paradise
Paradise copied to clipboard
[WIP][DNM] Fixes mind GC issues
What Does This PR Do
SO FAR: Fixes minds not GCing - Done and tested Refactors lavaland mob spawns into landmarks - Fixes GC issues and runtimes, done and tested TODO: Refactor mob/dead/observer -GC fails independent of the PR, but should happen if I'm trying to cut them all out Refactor mob/living/automatedannoucer -NFR but will likely do it (Boy this is due for one} Refactor mob/new_player -NFR and likely won't do Refactor give-up-body and aghost (Please do this properly admins) -NFR but should be done
Fixes #19323 Fixes #5597
Why It's Good For The Game
Short of it is that mobs have never had their owner removed on destroy. We're doing that and getting things not up to standard to standard. These things were really nasty, they would cause other things to fail to GC and wouldn't leave a reference. Now, why doesn't it leave a reference? Well that's because they would actually sit in the GC and not be processed, leading to nobody being sure why this stuff had problems beforehand, simply knowing that it did. Bottom line is that all this stuff was a problem before, we just weren't getting an SOS call on it. (We of course need to add a ? check as the mind may not yet be present, which is an issue that I want to resolve as it's a bandaid fix for a massive bleed.) WHY WE REFACTORED LAVALAND SPAWNERS: Lavaland spawners using the mob/random will cause an order of operations GC issue, runtimes, and is less efficenent than landmarks. They used to sit the GC queue and refuse to GC which is bad. Anyways I'm gonna be fleshing this out more soon with what I change more stuff
Testing
TODO
Changelog
:cl: experiment: Oh god oh fuck revert this PR ASAP /:cl: