Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Actual TCC (reinforced) walls port

Open ElorgRHG opened this issue 1 year ago • 7 comments

What Does This PR Do

Resprites reinforced walls, that's that.

Why It's Good For The Game

So https://github.com/ParadiseSS13/Paradise/pull/17887 has granted us new wall sprites and new floor sprites, now while the floor sprites are perfectly fine and don't think most people object to how they look, the reinforced walls are... well, not great. The PR said it was porting TCC walls, but not the reinforced ones, which are proprietary.

I mean no offense to whoever made the reinforced wall sprites for that PR of course, be it AA himself or someone he might've gotten them from.

And yes, I'm aware that this is a temporary solution as we're all awaiting the glorious 3/4 walls from McRamon, I'm doing this just so walls will look good till then.

Images of changes

Some bit of images (starring New Test Character I as the ghost):

image

image

image

image

Testing

Observed, went around the station to screenshot things for Images of changes

Changelog

:cl: imageadd: Replaced reinforced wall sprites. /:cl:

No shame in trying

ElorgRHG avatar Oct 16 '22 15:10 ElorgRHG

Will add a comment almost instantaneously I've heard that reinforced part of these have "dice" image

and I myself dont see it, but for those that do, how would this work instead

unknown (1)

problem with these is that deconstruction step sprites would look... bad. That's why I'm not in favor myself.

ElorgRHG avatar Oct 16 '22 16:10 ElorgRHG

Will add a comment almost instantaneously I've heard that reinforced part of these have "dice" image

and I myself dont see it, but for those that do, how would this work instead

unknown (1)

problem with these is that deconstruction step sprites would look... bad.

I had this exact sprite in during an earlier commit of #17887(See https://github.com/ParadiseSS13/Paradise/commit/9d6fd13732861f2b12fd2ba00d115d2eef9b9548 and https://github.com/ParadiseSS13/Paradise/runs/6919656141)

They were met with the argument of "you cant instantly tell its reinforced or not", which while I dont agree with, I shall bring it up either way for context.

AffectedArc07 avatar Oct 16 '22 16:10 AffectedArc07

Edit: I assumed affected meant the dice walls, not the "naked" ones 💀

I had this exact sprite in during an earlier commit of https://github.com/ParadiseSS13/Paradise/pull/17887(See https://github.com/ParadiseSS13/Paradise/commit/9d6fd13732861f2b12fd2ba00d115d2eef9b9548 and https://github.com/ParadiseSS13/Paradise/runs/6919656141)

They were met with the argument of "you cant instantly tell its reinforced or not", which while I dont agree with, I shall bring it up either way for context.

While admittedly I was not around for that TM due to having... certain events happening in my nearest proximity, I want to say that I really want to understand where that issue comes from, but I really don't, well not for the dice ones at least as these look plenty reinforced, I feel even the newest of players would be able to tell them apart.

The ones without the "dice" I could understand not being able to tell apart, the one with... yeah no.

image

ElorgRHG avatar Oct 16 '22 16:10 ElorgRHG

Yeah current reinforced walls are not really good visually wise. I'm pretty sure any player with eyeballs can notice a difference between regular and reinforced (even without the dice)

OctusGit avatar Oct 16 '22 19:10 OctusGit

Yeah current reinforced walls are not really good visually wise. I'm pretty sure any player with eyeballs can notice a difference between regular and reinforced (even without the dice)

Oh I fully agree. I only did the walls like that because heads refused to approve it otherwise.

AffectedArc07 avatar Oct 16 '22 19:10 AffectedArc07

Just wait for Ramon walls?

S34NW avatar Oct 16 '22 21:10 S34NW

Just wait for Ramon walls

3/4 walls require a lot more than just wall sprites, since things will need remapping to not be on the south side and similar. On top of that, it's not even a fully decided project, and it's still all up in the air on whether it fits or not.

AffectedArc07 avatar Oct 16 '22 22:10 AffectedArc07

Will add a comment almost instantaneously I've heard that reinforced part of these have "dice" image

and I myself dont see it, but for those that do, how would this work instead

unknown (1)

problem with these is that deconstruction step sprites would look... bad. That's why I'm not in favor myself.

I know I mentioned ramon walls earlier, but as for this PR the "no-dice" version of these definitely look better when repeating. If you can't tell it isn't reinforced by the ribbing then you need new eyes.

S34NW avatar Oct 24 '22 14:10 S34NW

RIP I dont really care all things considered, long live the alternative

ElorgRHG avatar Nov 04 '22 13:11 ElorgRHG