Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Adds ravens

Open Raven567 opened this issue 2 years ago • 13 comments

Ravendead

Ravenleft4

Ravenright4

What Does This PR Do

Adds a pet raven, updates the animal.dmi, with raven sprites ,and animations. Also adds the raven.dm script

Why It's Good For The Game

Because ravens are cool! And we need ravens!

Images of changes

image image

added 47 sprites It is roughly similar number as parrot.

Testing

I compiled the game, and used admin "animalize" in the player_pannel, to make sure all the animations, and interactions are working correctly. image I recently did a large update to the branch; adds a raven pet, "Nevermore to each of the stations chapels. image

Changelog

:cl: add: adds Raven animals! And the pet nevermore!

/:cl:

This is my first commit ever, I expect some criticism, and possible revision? Ravendead Ravenleftflyt

Ravenleft4

RavenflyRear-export

Ravenflyfront

RavenRightflyt

Raven567 avatar Oct 11 '22 03:10 Raven567

Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account.

Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php

Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion)

ParadiseSS13-Bot avatar Oct 11 '22 03:10 ParadiseSS13-Bot

Please include easily seen icons on your pr

McRamon avatar Oct 11 '22 04:10 McRamon

Fuck yeah, birds!

They look huge, though, compared to the other animals. We could have giant ravens, but we might want to call them "giant ravens", just to make sure it is intentionally this big!

Miraviel avatar Oct 11 '22 10:10 Miraviel

Code is looking good, go ahead and get your forum account linked.

Sirryan2002 avatar Oct 12 '22 15:10 Sirryan2002

Code is looking good, go ahead and get your forum account linked.

image

Raven567 avatar Oct 13 '22 01:10 Raven567

I still don't really know how things are done around here. So I am writing this manifesto. as part for the development team to review, and community as well.

I feel adding a new mob, and increasing variety to the game would be a positive outcome. However my considerations are as follows. -I wish to add flying at the later date, after this push request. I made this really to test the waters, and I want too keep things simple. However I have already started work on the flight animations, and I believe its easily achievable. Another reason is I want to refactor poly's code so I could build a foundation for making birds in the future for the whole team. -I have read through past commits and found that poly caused chaos, and was abused by players using it to rat out traitors and such. I think this is to be avoided, and I am seeking council on where the raven should be put, and what abilities it should have. At this time it only has the basic pet abilities, It can pretty much just caw and move around. For now I have put one raven in each chapel office, of each station. -Pixel art, I have received tremendous help form the community, and any suggestions on this regard will be taken to heart most likely. I want the best looking raven possible. And thank you all very much for your time, and reading my nonsense!

Raven567 avatar Oct 13 '22 02:10 Raven567

accounts linked

hal9000PR avatar Oct 13 '22 16:10 hal9000PR

Dead sprite is really something to be improved. Or at least made similar to Poly

McRamon avatar Oct 14 '22 18:10 McRamon

Dead sprite is really something to be improved. Or at least made similar to Poly

I need to do a refactor, people really want flying and perching and I need probably the weekend to work on this.

I think it would be cool too!

Raven567 avatar Oct 14 '22 20:10 Raven567

Poly is too much to refactor in one night!!! I'll work on the bird refactor another time! However I have added functionality to my raven, it can now caw! I also added functionality for flying when the pixel art is done! If one of you can tackle the flying animations that would be great! But I am working on them currently.

Raven567 avatar Oct 15 '22 06:10 Raven567

Is there a flying animation or does it just walk on the ground?

Denthamos avatar Oct 15 '22 17:10 Denthamos

I believe the project is in a pretty complete state! The pixel art is looking pretty decent to me, I am sure there are improvements always that could be made! The raven has two special abilities, The power to make an audible caw set on a cool down, also the ability to fly, and land. They can be found on here. image

Also id like to thank Sirryan2002 for helping me on every step of the journey! MrRamon and Azlan for your guys invaluable pixel art advise, and criticism, as well as Teri the community manager for emotional support. And I am probably not done, but this for my first commit has been a fantastic journey, just incase this is my last update.

Raven567 avatar Oct 16 '22 04:10 Raven567

Ravens now spawn in the NT office in each station, also added them to the syndicate station. Completely started fresh with the maps so hopefully there are no more issues.

Raven567 avatar Oct 17 '22 00:10 Raven567

Having more animals is cool, but making it spawn in Chapel, let alone the NT office makes no sense. I understand you wish to have a pet raven in game, but that doesn't mean everyone should deal with it every round.

We recently added bunnies because a few players wanted to have them, they are currently only accessible via supply pack crates. I suggest you do the same with ravens and remove them from the maps:

In code\datums\supplypacks.dm, add a raven crate below /datum/supply_packs/organic/bunny (copy-paste the bunny one and replace it with the raven's data, should be the same price), then in code\game\objects\structures\crates_lockers\crittercrate.dm, do the same at the end of the file. Then launch a test server, go to cargo, order one and see it works.

Miraviel avatar Oct 17 '22 06:10 Miraviel

Closed due to some very strange issues I have been unable to resolve; regarding maps. I will be reopening a new pull in an hour or so.

Raven567 avatar Oct 17 '22 07:10 Raven567