Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Ice Cream Cone Tweaks and New Sprites

Open PacifistDalek opened this issue 2 years ago • 1 comments

What Does This PR Do

Replaces the sprite for the ice cream itself, and adds a new waffle cone option to the ice cream maker, both sprites by Crumpaloo.

Tweaks a few aspects of the ice cream maker to make more logical sense, it does need a big refactor (and TGUIfication) but I'll save that for someone else or a later day.

Replaces the "Ice" button with a "Vanilla" button, because in many ways, vanilla is the default ice cream flavour so having easy access to it makes sense.

Changes the code that colours the ice cream to use an Hue Saturation Value colourspace, and puts some tweaks and clamps on the Saturation and Value (aka brightness) so that the ice creams are vibrant and colourful, not muted and greyish looking. Thanks to @Vi3trice for the code that let me do this.

Updates a whole bunch of the most egregious cases of drinks and a few other reagents that might be commonly used to make ice cream that had nonsensical colour values. (Lemon juice was red. Iced Coffee was blue. Banana juice was red. Etc.)

And finally, deletes a few unused icon states related to ice cream.

Why It's Good For The Game

This started as just a respriting project for the ice cream thanks to Crumpaloo's sprite work, but the Ice Cream Vat needs some heavy work. I don't have the time for a full refactor, but all these changes should at least make the user end of this machine much more sensical, even if the back end still needs that refactor.

Plus the ice cream looks way better!

Images of changes

image

Both images contain cones with identical reagents inside them. From top to bottom, they are 30u each of vanilla, tomato, lime, coffee, soy milk, grape juice, banana juice, and gin and sonic. image

Testing

Made all sorts of weird ice creams, played around with colourspace clamps and the like for hours.

Changelog

:cl: PacifistDalek, Crumpaloo, Vi3trice add: Waffle cones to the ice cream maker tweak: The ice cream maker makes more vibrant ice cream colours. Replaces Ice with Vanilla as options in the ice cream maker. Updates the colour hex codes assigned to a number of drinks and reagents to make them more realistic imageadd: New ice cream sprite /:cl:

PacifistDalek avatar Oct 09 '22 02:10 PacifistDalek

image image

I feel that the color of these 4 is very strong, if you can reduce it a little I think it would look better, but keeping the colors vibrant

DogeDogIs avatar Oct 09 '22 02:10 DogeDogIs

Tweaked them a touch, it's hard to find a middle ground where it doesn't kill the colour of non-bright ones: image

(also nothing can help Gin & Sonic it just looks like that no matter what :3 )

PacifistDalek avatar Oct 18 '22 15:10 PacifistDalek

Ah yeah and merge conflict needs resolving

S34NW avatar Oct 25 '22 13:10 S34NW

Absolutely Everything Broke, and I'm Having TROUBLE fixing it. Gonna close and start fresh on a new branch so I don't give myself a headache.

PacifistDalek avatar Oct 28 '22 14:10 PacifistDalek