Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

TGUI ORM MACHINE - Alloys Images

Open Oyu07 opened this issue 1 year ago • 8 comments

What Does This PR Do

Adds images to "Alloys" on ORM, a new recipe section for required materials, and also widens the UI a bit. Also adds a scroll bar to "Sheets Also gets rid off the "Ore Value" section for alloys as they dont have any

Why It's Good For The Game

Not everyone knows the materials name by heart, but know their icons. I believe this can help people find them easier. Also generally a cleaner look.

Images of changes

---CURRENT VERSION--- resim

---THIS PR--- resim

Testing

  • Boot up local server
  • [x] Try in TGUI Dev
  • [x] Try in TGUI Production

Changelog

:cl: add: ORM UI cleanup add: Images for Alloys add: Recipe section for alloys (shows what materials are used/needed for the alloy) del: ORM No longer displays ore value gap for alloys tweak: ORM is wider tweak: "SMELT" and "ORE-VALUE" switched places /:cl:

Oyu07 avatar Sep 19 '22 18:09 Oyu07

forgot a commit, please wait

Oyu07 avatar Sep 19 '22 19:09 Oyu07

a nitpick of the UI, could you arrange the columns so that the number input columns line up between the two sections?

Sirryan2002 avatar Sep 22 '22 13:09 Sirryan2002

a nitpick of the UI, could you arrange the columns so that the number input columns line up between the two sections?

want the Alloys section, "Available" and "Smelt" sections to switch places basically? And also I will see what I can do to get them matched up better, worst case, TGUI gets wider into a square

Oyu07 avatar Sep 22 '22 15:09 Oyu07

I won't be upset if they're a little out of line, I'd just like them to be in relatively the same lane. Could you try moving the ore value to the 2nd column? That may help a bit.

Sirryan2002 avatar Sep 23 '22 17:09 Sirryan2002

been busy lately, will update on weekend

Oyu07 avatar Sep 29 '22 08:09 Oyu07

I won't be upset if they're a little out of line, I'd just like them to be in relatively the same lane. Could you try moving the ore value to the 2nd column? That may help a bit.

resim

Oyu07 avatar Oct 01 '22 09:10 Oyu07

Love the alloy images, however I don't like how the addition of the recipe column throws off the symmetry between the alloy and metal sheets section.

This also results in you having to copy and paste a lot of code from <SheetLine> to make <AlloyLine>.

SteelSlayer avatar Oct 01 '22 22:10 SteelSlayer

Love the alloy images, however I don't like how the addition of the recipe column throws off the symmetry between the alloy and metal sheets section.

This also results in you having to copy and paste a lot of code from <SheetLine> to make <AlloyLine>.

It resulted in basically copy paste of the entire code yes, but without it, alloys would still display ore value, which they do not have, and that was the result of removing it. And then there was a huge negative space in between. But thanks for the feedback, it is not a perfect solution, but it is a solution that does not have big empty space. But as always, feedbacks and discussions are welcome. The recipe tab started from a request to make used materials grey for example.

Oyu07 avatar Oct 01 '22 23:10 Oyu07