Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Removes lavaland swarmer crash ruin (Its already disabled on the server anyway)

Open AffectedArc07 opened this issue 2 years ago • 0 comments

INITIAL NOTE

"But affected stop removing stuff for no reason!!111"

Not only do I have plenty of reason for this, its already disabled on the production server anyway. This PR changes nothing ingame apart from a technical debt cleanup.

What Does This PR Do

Removes the lavaland AI swarmer ruin, as well as associated code.

Why you may ask? Well, get ready for a ramble.

Not only does this ruin not provide much outside of a crystal farm for those who dont want to mine as much, this is one of the worst performing things on the server, and I dont say that lightly. It is worse than atmos.

Swarmers expand exponentially, further adding to the mob count, and so long as theres a single player on the z-level, the AI will be active and processing, all of the swarmers calculating movements, gathering to reproduce, etc etc etc. All of this revovles around using lots of timers as well, which doesnt help the timer bucket issue.

"Oh just delete them in that round if they lag"

Did you know these things have a 100% GC fail rate? image The ones that are 1 off didnt stay alive long enough to be marked as fails before the server ends

This high destroy cost will lag the hell out of SSgarbage when it fires, which slows the entire rest of the server down.

Why It's Good For The Game

Removal of bad gameplay + gaining performance? Whats not to love

Changelog

:cl: AffectedArc07 del: Removed lavaland swarmer crash ruin. /:cl:

AffectedArc07 avatar Aug 14 '22 10:08 AffectedArc07