Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Buffs the powerfist

Open PopeDaveThe3th opened this issue 1 year ago • 2 comments

What Does This PR Do

Reduces powerfist gas consumption by 5/6ths.

Adds nodrop whenever a gas tank is inserted into the fist, removes nodrop when the tank is removed.

Why It's Good For The Game

The powerfist is a fairly terrible traitor item, having some of the worst ammo efficiency of any weapon in the game. With a stock oxygen tank, you can use the fist's maximum setting only twice before running dry.

This PR aims to make the fist a bit more competitive as a damage dealer.

Additionally, nodrop was added at the request of Qwertytoforty.

Testing

  • Loaded test server
  • Spawned fist
  • Tested loading and unloading the fist. (works with both stock oxygen and plasma tanks)
  • Beat numerous vox to death
  • Fist works as intended

Changelog

:cl: tweak: Buffed the powerfist, lowering gas consumption and adding nodrop /:cl:

PopeDaveThe3th avatar Aug 13 '22 03:08 PopeDaveThe3th

what happens when you put a tank in the fist without holding the fist?

hal9000PR avatar Aug 15 '22 20:08 hal9000PR

what happens when you put a tank in the fist without holding the fist?

It still shows the "locks around your arm" message, but the nodrop is applied as usual and removed if you pop the tank out.

I can change the tank insert message to be a bit more ambiguous if you'd like.

PopeDaveThe3th avatar Aug 15 '22 22:08 PopeDaveThe3th

Can you check to see what happens when someone's arm gets blown off while using the powerfist. If the powerfist gets dropped from this, it shouldn't immediately glue itself to someone's hand if they pick it up off the ground.

Would it be acceptable if I made it so that you can't pick the fist up while a tank is inserted?

PopeDaveThe3th avatar Aug 18 '22 00:08 PopeDaveThe3th

It should remove the NODROP upon a limb being blown off due to the base item dropped() proc, however I'm just asking you to test to see if this is actually the case.

Sirryan2002 avatar Aug 18 '22 03:08 Sirryan2002

It should remove the NODROP upon a limb being blown off due to the base item dropped() proc, however I'm just asking you to test to see if this is actually the case.

Can confirm, blew self up with a grenade, lost left arm, fist dropped even though I was holding it in my right arm. The nodrop is reapplied by extracting and replacing the tank.

I'll chalk this one up lorewise to "emergency failsafe that prevents you from getting the fist permanently stuck if you lose a limb".

PopeDaveThe3th avatar Aug 18 '22 22:08 PopeDaveThe3th

Your Fix/Feature pull request is currently below zero (-7). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions[bot] avatar Aug 25 '22 15:08 github-actions[bot]