Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Small container transfer rate change improvements

Open CinnamonSnowball opened this issue 2 years ago • 0 comments

What Does This PR Do

  1. Fixes certain reagent containers having lists of possible transfer rates that were either empty, contained only the default value, or were not even lists. All of these were intended to have fixed transfer rates, but triggered the Alt-click to change the transfer amount. examine message and had the Set transfer amount verb regardless. All of these were changed to null which blocks altering the transfer rate, suppresses the examine message, and removes the verb when initializing.
  2. Moved the sanity checks around in set_APTFT() so that canceling while in a position that would normally trigger one of the warnings does not produce one (since you're choosing to do nothing anyway).
  3. Added a quality-of-life feedback message when transfer rate of a container was changed successfully.

Why It's Good For The Game

Bugs bad, avoiding negative feedback when it doesn't matter good, feedback on action success good.

Testing

  • Spawned in a syringe (had possible_transfer_amounts = list()), a damp rag (list(5)), and a baggie (2).
  • Examined all of 'em, saw no transfer rate modification note
  • Picked up all of 'em, saw no Set transfer amount verb in Object tab
  • Alt+Clicked all of 'em, saw you still can't change the transfer amount ​
  • Alt+Clicked a beaker while in range
  • Moved away from beaker during the input prompt
  • Cancelled the input, saw no unnecessary You have moved too far away! warning message
  • Re-tested the intended use of the warning, saw that it still shows up ​
  • Alt+Clicked a beaker while in range
  • Successfully selected one of possible transfer rates, saw new feedback message
  • Re-tested the fail case, saw that the new feedback message correctly doesn't show up

Changelog

:cl: add: Successfully changing a reagent container's transfer rate now produces a reassuring feedback message fix: Fixed some reagent containers with fixed transfer rates showing the Alt+Click transfer rate change examine note /:cl:

CinnamonSnowball avatar Aug 11 '22 15:08 CinnamonSnowball