Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

Rework disease outbreak event

Open alex-gh opened this issue 1 year ago • 6 comments

What Does This PR Do

Splits the disease outbreak event into mundane, moderate and major versions. Removes the level 7 biohazard announcement Reworks the random advanced disease generation to make a disease with a severity that fits the event level. Makes the event infect a new arrival instead of a random person on the station level. That person becomes an infectious carrier, but unaffected by the disease itself. Fixes buggy random disease generation ( Fixes #13787 )

Why It's Good For The Game

Removal of the level 7 biohazard announcement provides plausible deniability for antagonist virologists. Makes mild diseases more common, making the virologists job a bit more important. Infecting a new arrival instead of a person on the station no longer has the potential to screw up a random antags run. And it is more realistic.

Testing

Tested locally. Works as intended as far as I can tell.

Notes

A test merge might be useful to test if the chosen values and diseases make sense

Changelog

:cl: uc_guy fix: Fixed randomly generated viruses showing incorrect cures and spread methods. del: Removed Level 7 Biohazard annoucement. tweak: The disease outbreak event now can appear in multiple severities. tweak: Disease outbreak event infects a new arrival instead of a random person. That person becomes an infectious carrier, but unaffected by the disease itself. /:cl:

alex-gh avatar Jul 31 '22 13:07 alex-gh

I don't like the idea of infecting new arrivals instead of a random person. Not everyone is located close to this server. Sometimes it takes me a long time to connect and for everything to load. Giving new arrivals diseases such as brainrot is not good when they might have to reconnect and fix issues. If anything I think we should protect new arrivals more than antags. You shouldnt be screwed over the moment you connect to the server. I also dislike the idea of virologists setting up booths close to the arrivals shuttle to cure newly arrived people.

I do however love the idea of removing the level 7 announcement and making the event have different levels. This will make the viro role more interesting.

TORE01 avatar Jul 31 '22 15:07 TORE01

Yeah, connection issues are a valid issue. I'll see if I can work around that.

As for virologists setting up booths in arrivals. That is quite unlikely. What are they going to do, sit there for the most of the round on the off chance the disease outbreak event triggers?

alex-gh avatar Jul 31 '22 16:07 alex-gh

Yeah, connection issues are a valid issue. I'll see if I can work around that.

As for virologists setting up booths in arrivals. That is quite unlikely. What are they going to do, sit there for the most of the round on the off chance the disease outbreak event triggers?

It's the new viro meta.

  1. Make sure your middlename is Norton
  2. Make virus
  3. Camp arrivals until virus spawn

TORE01 avatar Jul 31 '22 16:07 TORE01

Alright, I have fixed the new arrival problematic: Now the infected person becomes a carrier. Unaffected by the disease, but still able to spread it.

This way we still have the intended effect of introducing a new virus to the station without griefing new arrivals that might have connection issues.

alex-gh avatar Jul 31 '22 22:07 alex-gh

Alright, I have fixed the new arrival problematic: Now the infected person becomes a carrier. Unaffected by the disease, but still able to spread it.

This way we still have the intended effect of introducing a new virus to the station without griefing new arrivals that might have connection issues.

I love this idea, but carriers can still infect other new arrivals that happen to connect at the same time. It's still a nice change imo.

TORE01 avatar Aug 01 '22 01:08 TORE01

I love this idea, but carriers can still infect other new arrivals that happen to connect at the same time. It's still a nice change imo.

At that point they're just unlucky imo. They could aswell have caught it from someone infected who happened to be walking through arrivals, or spawned in a breached shuttle.

Inadvizable avatar Aug 02 '22 14:08 Inadvizable

Sorry. Screwed massively up with git.

alex-gh avatar Aug 27 '22 21:08 alex-gh