Paradise icon indicating copy to clipboard operation
Paradise copied to clipboard

[TGUI] Implant Pad + Implanter Related Sprites + Slight Implant refactor

Open Sirryan2002 opened this issue 1 year ago • 7 comments

What Does This PR Do

Does a few things

  1. Adds new sprites for implant cases, the implant pad, and implanters -Implant Pad + Case Sprite are of my own work -New Implanters were sprited in TG Station #66722 by PestoVerde322
  2. Refactors Implant Code, mostly all just cleanup, implantpad had a few changes, also put an autosurgeon sprite as the base implant icon state so that it's not broken in-game (I know this is "sprite debt" but broken icons cause significant client lag upon examination/display)
  3. Removes the ID var on tracking implants as they did absolute jack shit
  4. Ensures all Implants have implanters and implant cases defined in the code
  5. Ports the Implantpad to TGUI
  6. Fixes #18693

Why It's Good For The Game

Sometimes you just need to update some crusty ass sprites that have outlived their time period. Also it's nice to have more code brought up to modern styling standards.

Project Progression -> #18493 and #14968

Images of changes

Lovely Images

ImplantCompare

padnocase

padcasenoimplant

padimplant

padimplant2

Next things on my shitlist after this PR

  1. Implant Chair
  2. Locater

Changelog

:cl: add: Adds implanters + implant cases for every implanter implant available del: Removed ID setter on implantpad tweak: Implant Pad is now TGUI instead of browserUI imageadd: Implant Cases have new sprites imageadd: Implanters have new sprites /:cl:

Sirryan2002 avatar Jul 25 '22 01:07 Sirryan2002

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

S34NW avatar Jul 25 '22 15:07 S34NW

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

I really don't want to up the files changed on this PR by 30 files + a couple map edits, unless you mean just changing their name variable?

Sirryan2002 avatar Jul 25 '22 15:07 Sirryan2002

This might be out of scope, but could we perhaps rename these from "implants" to differentiate from the surgery-implanted implants? (eye-shield, nodrop, CNS, etc.)

I really don't want to up the files changed on this PR by 30 files + a couple map edits, unless you mean just changing their name variable?

Yeah just renaming them to the end user, coders will already know it's a different item.

S34NW avatar Jul 25 '22 16:07 S34NW

You could, for example, call them "microchips" or something

S34NW avatar Jul 25 '22 16:07 S34NW

You could, for example, call them "microchips" or something

Would prefer to change the name of cybernetik implants over changing these ones. That will need to be done in a separate PR

Sirryan2002 avatar Jul 25 '22 16:07 Sirryan2002

will try and get to this soonish

Sirryan2002 avatar Aug 01 '22 16:08 Sirryan2002

Will have requested changes done in the next 3-4 days. Currently dealing with a 40 hour work week 💀

Sirryan2002 avatar Aug 07 '22 18:08 Sirryan2002

still need to fix issues with uplink implants due to conflicts

Sirryan2002 avatar Aug 25 '22 02:08 Sirryan2002

I promise I'm not forgetting about this PR, just working through early university setup stuff atm

Sirryan2002 avatar Aug 30 '22 03:08 Sirryan2002