parabol icon indicating copy to clipboard operation
parabol copied to clipboard

Discussion: Emoji dialog closes when another user adds a reaction

Open Dschoordsch opened this issue 2 years ago • 11 comments

How to reproduce

Adam and Bertram participate in a Check-In in the agenda discussion with one comment without reactions. Adam opens the emoji dialog. While the dialog is open, Bertram adds a reaction to the same comment.

Expected behaviour

The dialog stays open and Adam can continue adding their reaction.

Actual behaviour

The dialog closes and Adam has to open it again

Comment

This probably happens because the button switches position, so it's probably a newly mounted component. This means the dialog should move up the component tree.

EE: 4h

Dschoordsch avatar Jan 05 '23 10:01 Dschoordsch

hey @Dschoordsch how are you?

I would love to explore this ticket. Is it possible to tackle bugs as an outside contributor? It's not listed as part of the EFE tickets, but is a great place to start exploring the codebase.

Please let me know. Thanks 🤝 .

bahdcoder avatar Jan 10 '23 11:01 bahdcoder

I think that's a great idea. As this is a P3 it's unlikely we pick it up soon, so outside contributions are more than welcome. @jordanh any objections?

Dschoordsch avatar Jan 10 '23 11:01 Dschoordsch

Thank you @Dschoordsch for the mention!

@bahdcoder yes, I place this one in our E4E program and assign you as the owner. Recently we've had a relatively high "abandon" rate for E4E work. In the past, we would execute a contract straight away that would make it clear that you're performing this work under E4E and would accrue points under that program. That costs us operations/lawyer time on our side and I'd like to make sure you're make it to the finish line on your first issue before we go through the trouble to put paper in place.

Could you let us know when you're ready to open a PR for review and then we'll send you a contract to review for the work?

jordanh avatar Jan 17 '23 19:01 jordanh

@bahdcoder out of curiosity, are you still working on this issue or would it be ok for us to reassign it?

jordanh avatar Feb 28 '23 19:02 jordanh

hey @jordanh If he isn't responding please assign this issue to me. I would try to take a shot at it!

Narcos101 avatar Apr 07 '23 12:04 Narcos101

@Narcos101 please go ahead an take a shot at it!

jordanh avatar Apr 11 '23 17:04 jordanh

@Dschoordsch Do you have a discord or a slack id so that i can ask doubts to you?

Narcos101 avatar Jun 02 '23 10:06 Narcos101

Hey there, if the issue is still active and if @Narcos101 is okay with it, can I pick this up?

Mohd-Muneeb avatar Apr 08 '24 11:04 Mohd-Muneeb

There was no activity for a long time, feel free to pick this one up.

Dschoordsch avatar Apr 08 '24 11:04 Dschoordsch

Cool. Thank you!

Mohd-Muneeb avatar Apr 10 '24 15:04 Mohd-Muneeb