parabol icon indicating copy to clipboard operation
parabol copied to clipboard

feat(notifications): Auto-open notifications from email

Open jmtaber129 opened this issue 2 years ago • 1 comments

Description

Our current notifications simply go to the user's tasks page with no additional information.

Instead, include a query param on notification summary email links, and when this parameter is present, auto-open the notifications menu after some delay.

I may want to hold off on merging this until after the next release, so we can first get some baseline data from the UTM parameters.

Demo

https://www.loom.com/share/0b150be30ad04f9d89ea73e6a36d11dd

Testing scenarios

  • [ ] Trigger a notification email for a user
    • [ ] Trigger a notification for a user
    • [ ] Modify the sendBatchNotificationEmails mutation to send regardless of whether the user was active in the past day by deleting this clause and removing yesterday.
    • [ ] Run mutation{sendBatchNotificationEmails} to trigger
  • [ ] Open the notification email and click the "See my dashboard" CTA
  • [ ] See that the notification menu is open
  • [ ] Close the menu and click around a bit, and confirm that the menu doesn't reopen automatically

Final checklist

  • [X] I checked the code review guidelines
  • [X] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [X] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [X] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [X] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [X] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [X] PR title is human readable and could be used in changelog

jmtaber129 avatar Sep 23 '22 00:09 jmtaber129

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 23 '22 00:09 sonarqubecloud[bot]

@mattkrick I'd normally call this "one review required", but this introduces a new pattern - triggering an action on-load via query parameter, in this case for a link in an email, but potentially for enhanced shareability in other parts of the product (e.g. sharing a specific task card).

jmtaber129 avatar Sep 26 '22 19:09 jmtaber129