parabol icon indicating copy to clipboard operation
parabol copied to clipboard

fix: Aria-label “edit this reflection” should not exist when the reflection is no longer editable

Open 87prashant opened this issue 2 years ago • 1 comments

Description

Fixes #7107

Testing scenarios

Check if the screen readers read edit this reflection for non-editable reflections in different phases and different scenarios (for ex: when a phase is completed)

Final checklist

  • [x] I checked the code review guidelines
  • [ ] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [ ] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

87prashant avatar Sep 22 '22 05:09 87prashant

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 22 '22 05:09 sonarqubecloud[bot]