parabol
parabol copied to clipboard
fix: Snackbar messages are not bottom centered during standups
Description
Fixes/Partially Fixes issue
After digging, I discovered that the snackbar was positioned relative to the sidebar on the left, so this affected the positioning on pages that the sidebar isn't in view.
I modified the code to add the width of the sidebar to the position of the snackbar only when the screen is desktop when the page is not a meeting i.e when the sidebar is showing.
Before the bug fixed
After the bug fixed




Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
-
[ ] Scenario A
- Step 1
- Step 2...
-
[ ] Scenario B
- Step 1
- Step 2....
Final checklist
- [x] I checked the code review guidelines
- [ ] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
- [x] I have performed a self-review of my code, the same way I'd do it for any other team member
- [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
- [ ] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
- [ ] I added the label
One Review Required
if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient' - [ ] PR title is human readable and could be used in changelog
Hi @Dschoordsch, @igorlesnenko, @JimmyLv this PR has been up for a while now, no clue of the failing actions. but you can advise accordingly.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@gitstart thank you for contributing. do you mind filling the PR template accordingly? I see the default values for testing scenarios. thank you!
@gitstart thank you for contributing. do you mind filling the PR template accordingly? I see the default values for testing scenarios. thank you! Hi BartoszJarocki, the PR description was updated, you can give another look to the PR.
Hi @BartoszJarocki, this PR is ready for review.
Thank you for looking into this. I left a couple of comments.
@BartoszJarocki the requested changes have been implemented, please check again.