parabol icon indicating copy to clipboard operation
parabol copied to clipboard

fix: Use MaterialUI SvgIcons instead of Font

Open Dschoordsch opened this issue 2 years ago • 5 comments

Description

Fixes #6062

Use Material UI SVG icons instead of the font

Demo

No demo, app should look the same.

Testing scenarios

Use the whole app, ideally running release testing procedure to check that all screens look as intended.

Final checklist

  • [ ] I checked the code review guidelines
  • [ ] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [ ] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [ ] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [ ] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [ ] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [ ] PR title is human readable and could be used in changelog

Dschoordsch avatar Sep 06 '22 09:09 Dschoordsch

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions[bot] avatar Sep 06 '22 10:09 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions[bot] avatar Sep 16 '22 11:09 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions[bot] avatar Sep 16 '22 16:09 github-actions[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

sonarqubecloud[bot] avatar Sep 16 '22 16:09 sonarqubecloud[bot]

The current implementation increases the bundle size. Since the images are components, these are also not cached, degrading the performance overall. Initial load increases from 5.0 to 5.2 MB.

Dschoordsch avatar Sep 19 '22 10:09 Dschoordsch

degrading the performance overall

That's sad, any way we can improve it?

87prashant avatar Sep 24 '22 15:09 87prashant

degrading the performance overall

That's sad, any way we can improve it?

I think we have to go the SVG route, i.e. downloading the used icons as SVG and using those as images. This will probably not change the download size much, but it makes it possible to cache the images in the browser. As components these will need to be loaded each release. Not a huge deal, but when we touch this, we should do it right.

Dschoordsch avatar Sep 26 '22 07:09 Dschoordsch

degrading the performance overall

That's sad, any way we can improve it?

I think we have to go the SVG route, i.e. downloading the used icons as SVG and using those as images. This will probably not change the download size much, but it makes it possible to cache the images in the browser. As components these will need to be loaded each release. Not a huge deal, but when we touch this, we should do it right.

I made a mistake when measuring as I did not properly minimize the chunks (I did not pass --deploy). When properly done, the size is virtually identical, so we can move on with this.

Dschoordsch avatar Oct 20 '22 11:10 Dschoordsch

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions[bot] avatar Oct 20 '22 14:10 github-actions[bot]

@igorlesnenko I know you've taken a look at this before the rebase, but could you please just do a quick glance over if there is something obviously wrong?

Dschoordsch avatar Oct 20 '22 14:10 Dschoordsch

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

github-actions[bot] avatar Nov 02 '22 14:11 github-actions[bot]