parabol icon indicating copy to clipboard operation
parabol copied to clipboard

Add noImplicitAny to client config (Part 1 of X)

Open mattkrick opened this issue 3 years ago • 1 comments

Now that the server config has noImplicitAny turned on, we'll want to do the same for the client

So, I propose we share the love & chip away at it. Instead of turning the rule off & on, @jmtaber129 suggested we do what the tsc team does: https://code.visualstudio.com/blogs/2019/05/23/strict-null

  • [x] create a tsconfig.noImplcitAny.json in the client
  • [x] that config has noImplicitAny & a list of files (or an include section)
  • [x] we slowly add to the files that get checked
  • [ ] our git hook & CI runs a check using this config in parallel to current typechecks
  • [x] create a copy of this issue named Part (2 of x) so we can re-prioritize for the next person. We'll keep doing this until it's done

AC

  • [x] config file setup & 200 noImplicitAny errors fixed on client

Estimate: 4 hours

mattkrick avatar Sep 02 '22 20:09 mattkrick

fixed by #7192 #7193

mattkrick avatar Sep 19 '22 17:09 mattkrick

Stale issue

github-actions[bot] avatar Mar 19 '23 00:03 github-actions[bot]

already fixed

mattkrick avatar Mar 27 '23 21:03 mattkrick