parabol icon indicating copy to clipboard operation
parabol copied to clipboard

Aria-label “edit this reflection” should not exist when the reflection is no longer editable

Open acressall opened this issue 3 years ago • 3 comments

Issue - Bug

Reflection cards maintain the editing markup even when the reflections are no longer editable. The biggest issue here is we have an area label that says "edit this reflection" when it is not editable. This problem for group, vote, and discussion phases.

Acceptance Criteria (optional)

Users can:

  • no longer be told that a div allows them to edit a reflection when editing is disabled Triage is performed to find the root cause of the bug, timeboxed to ~1 hour.

Estimated effort: 1 hour to triage. More if root cause is already identified.

acressall avatar Aug 24 '22 16:08 acressall

@acressall Is this creating any issues? I was checking with a screen reader and I was not able to find any issue as it reads edit this reflection only when the text is editable. Or am I missing something?

87prashant avatar Sep 21 '22 03:09 87prashant

I'm using VoiceOver on the Mac, and the text Edit this reflection is announced to screen readers when the user moves their VoiceOver focus to the reflection card, regardless of what phase the meeting is in.

In the Group phase users can edit their own reflections (but not the ones created by others), and on theVote and Discuss phases reflections are no longer editable, regardless of who the author is.

enriquesanchez avatar Sep 21 '22 16:09 enriquesanchez

Ok, thanks. BTW I am testing with NVDA

87prashant avatar Sep 21 '22 16:09 87prashant