Sprint Poker: number of stories in summary stats is one less than actual stories

[enriquesanchez]

Issue - Bug

When a Sprint Poker meeting has ended, the number of stories in the summary stats is one less than the actual number of stories that were estimated.

Note that the stats at the top says 8 but the list of stories estimated below totals 9.

• How serious is the bug? P4
• OS: Unspecified
• Browser: Unspecified

Acceptance Criteria (optional)

• Number of stories in the summary stats is equal to the number of stories estimated

Estimated effort: 1 hour to triage. More if root cause is already identified.

[enriquesanchez]

A user writes (🔒):

Whenever we get our meeting summary the amount of stories is incorrect at the top in the summary area. For example, today we had 9 stories and all of them are listed in the summary but the top only says 8 stories. Can you let me know if i'm missing something or not doing it correctly that it is always 1 off?

[87prashant]

These are not total stories, these are completed stories In this case, the last story is not considered completed when we click End meeting

• Either we can change the name above "stories" => "completed stories"
• Or change the value to show the total stories

@enriquesanchez WDYT?

[sophiaenax]

@enriquesanchez @87prashant I want to work on this issue. What approach should I take? Renaming to completed stories or changing the value to show total stories?

[enriquesanchez]

In this case, the last story is not considered completed when we click End meeting

Oh, interesting. How did you arrive to that conclusion, @87prashant ?

[enriquesanchez]

Just tested this again, on a Sprint Poker meeting where I estimated 5 issues, and I got a total of 4 reported in the stats.

[87prashant]

@enriquesanchez

https://user-images.githubusercontent.com/106697681/188045902-aafdaa00-8087-4678-8590-bbda920c49a4.mp4

[87prashant]

I think to make it total stories we can do this:

[enriquesanchez]

@Dschoordsch would you mind taking a look and advise how to proceed with this bug?

[Dschoordsch]

Thanks @87prashant, you're right. I think there are 2 issues here:

1. we only count completed stages, this was done by @nickoferrall here, sadly without any additional information. So this seems intended but might be a bit confusing for users when it's just named "stories"
2. not all voted stories marked as completed reliably

[nickoferrall]

@mattkrick you mentioned https://github.com/ParabolInc/parabol/pull/5062#pullrequestreview-691232842 that we should count the completed stories. Not sure if you have any strong feels on this?

We could change the "Stories" title to "Completed Stories". I also have no tension counting all stories, rather than completed stories.

[mattkrick]

I've got a slight preference to keep it to completed stories because I've seen cases where folks add like 50 & then complete as many as they can get to, which makes for less visual noise.

The big question for me is why are stories not marked as completed? when end meeting is called it should mark the stages started as completed. if we solve that i think we fix the issue!

[87prashant]

when end meeting is called it should mark the stages started as completed

All stages?

Just confirming, are we choosing completed stories or all stories?