parabol
parabol copied to clipboard
feat(metrics): add 'inviterId' to Invite Accepted events
Description
Fixes #6973
Demo

Testing scenarios
- [ ] Scenario A
- Inviter invites someone to the team
- Invitee accepts the invitation
- Verify the
inviterId
in theInvite Accepted
event is theuserId
of the inviter
Final checklist
- [x] I checked the code review guidelines
- [x] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
- [x] I have performed a self-review of my code, the same way I'd do it for any other team member
- [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
- [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
- [x] I added the label
One Review Required
if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient' - [x] PR title is human readable and could be used in changelog
@tianrunhe would it make sense to also create a similar event to capture the inviter's action? E.g. something like "Sent invite accepted" tied to the inviter to enable us to answer questions like "what's the conversion rate from sign up -> invited a user that accepted the invitation" in Amplitude, and also generally capture more of the user journey of the inviter.
@tianrunhe would it make sense to also create a similar event to capture the inviter's action? E.g. something like "Sent invite accepted" tied to the inviter to enable us to answer questions like "what's the conversion rate from sign up -> invited a user that accepted the invitation" in Amplitude, and also generally capture more of the user journey of the inviter.
I like that and have created an issue