parabol icon indicating copy to clipboard operation
parabol copied to clipboard

feat(metrics): add 'inviterId' to Invite Accepted events

Open tianrunhe opened this issue 2 years ago • 2 comments

Description

Fixes #6973

Demo

Screen Shot 2022-08-11 at 3 36 50 PM

Testing scenarios

  • [ ] Scenario A
    • Inviter invites someone to the team
    • Invitee accepts the invitation
    • Verify the inviterId in the Invite Accepted event is the userId of the inviter

Final checklist

  • [x] I checked the code review guidelines
  • [x] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

tianrunhe avatar Aug 11 '22 22:08 tianrunhe

@tianrunhe would it make sense to also create a similar event to capture the inviter's action? E.g. something like "Sent invite accepted" tied to the inviter to enable us to answer questions like "what's the conversion rate from sign up -> invited a user that accepted the invitation" in Amplitude, and also generally capture more of the user journey of the inviter.

jmtaber129 avatar Aug 11 '22 22:08 jmtaber129

@tianrunhe would it make sense to also create a similar event to capture the inviter's action? E.g. something like "Sent invite accepted" tied to the inviter to enable us to answer questions like "what's the conversion rate from sign up -> invited a user that accepted the invitation" in Amplitude, and also generally capture more of the user journey of the inviter.

I like that and have created an issue

tianrunhe avatar Aug 11 '22 22:08 tianrunhe