parabol icon indicating copy to clipboard operation
parabol copied to clipboard

fix: Fixed Discussion drawer is not accessible on mobile devices

Open gitstart opened this issue 2 years ago • 7 comments

Description

Fixes/Partially Fixes #6858

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • [ ] Scenario A

    • Step 1
    • Step 2...
  • [ ] Scenario B

    • Step 1
    • Step 2....

Final checklist

  • [x] I checked the code review guidelines
  • [x] I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • [x] I have performed a self-review of my code, the same way I'd do it for any other team member
  • [x] I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • [x] Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • [x] I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • [x] PR title is human readable and could be used in changelog

gitstart avatar Aug 08 '22 08:08 gitstart

@igorlesnenko please can you review?

gitstart avatar Aug 09 '22 11:08 gitstart

@gitstart can you please link the original issue?

igorlesnenko avatar Aug 09 '22 11:08 igorlesnenko

@igorlesnenko added link to original issue. Thanks for the feedback

gitstart avatar Aug 10 '22 10:08 gitstart

Hi @Dschoordsch, requested changes have been implemented you can give this PR another look.

gitstart avatar Sep 13 '22 10:09 gitstart

Working fine on Firefox, but is currently not supported on Chrome.

Screenshot 2022-09-13 172714

87prashant avatar Sep 13 '22 12:09 87prashant

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Sep 20 '22 11:09 sonarcloud[bot]

Hi @Dschoordsch, reverted to the requested changes you can take a look once again.

gitstart avatar Sep 20 '22 12:09 gitstart

Hi @Dschoordsch, closing this PR we are not able to complete works to.

gitstart avatar Oct 07 '22 05:10 gitstart

The dvh supported on safari and firefox currently and probably coming on android mobile. Could we move forward with dvh? @Dschoordsch WDYT?

87prashant avatar Oct 27 '22 12:10 87prashant

@87prashant we could do that. We can combine the solution from @gitstart with dvh where supported, similar to https://github.com/ParabolInc/parabol/blob/0d46c2542ff7e7d78bbf5c8c0104a287858afb69/packages/client/components/TeamPrompt/TeamPromptDiscussionDrawer.tsx#L43-L46

Dschoordsch avatar Oct 27 '22 12:10 Dschoordsch

dvh now supported on chrome android.

87prashant avatar Jan 09 '23 03:01 87prashant