parabol icon indicating copy to clipboard operation
parabol copied to clipboard

Published 20 hours ago • verified publisher icon ParabolInc

feat: Updated new meeting settings area

Open igorlesnenko opened this issue 3 years ago • 4 comments

Fixes #5603

Next PR: #7001

image image

How to test:

  • Open new meeting dialog
  • Make sure all new controls works for all meeting types bot on mobile and desktop

igorlesnenko avatar Aug 02 '22 18:08 igorlesnenko

@JimmyLv can you review this PR please?

igorlesnenko avatar Aug 08 '22 11:08 igorlesnenko

+1 For mobile, can we center the active meeting in the carousel so the previous & next options are both slightly visible? that way folks can go back & forth just by tapping instead of swiping

mattkrick avatar Aug 09 '22 22:08 mattkrick

@mattkrick I tried to fix that quickly, but was unable to, as possibly, there is a bug in the library.

Also, since in this PR I only touched settings part of the dialog, I created a separate issue and will look into it: #7040

Is it ok?

igorlesnenko avatar Aug 10 '22 20:08 igorlesnenko

@igorlesnenko i think i got it working: https://www.loom.com/share/d9a85b1904be463ea3cb7401e8f4e47d

If you like what you see, go ahead & merge https://github.com/ParabolInc/parabol/pull/7061 into this PR.

aside from that, lgtm

mattkrick avatar Aug 12 '22 01:08 mattkrick

@mattkrick I left comments in your PR: https://github.com/ParabolInc/parabol/pull/7061#pullrequestreview-1071109618

I'm merging this PR for now

igorlesnenko avatar Aug 12 '22 13:08 igorlesnenko