parabol
parabol copied to clipboard
feat: Updated new meeting settings area
Fixes #5603
Next PR: #7001
![image](https://user-images.githubusercontent.com/466991/182443290-6f99b637-9fbd-4622-aa3e-fcea920ad8ad.png)
![image](https://user-images.githubusercontent.com/466991/182443361-8553af5e-bcfb-4bfb-b651-24f256a3256e.png)
How to test:
- Open new meeting dialog
- Make sure all new controls works for all meeting types bot on mobile and desktop
@JimmyLv can you review this PR please?
+1 For mobile, can we center the active meeting in the carousel so the previous & next options are both slightly visible? that way folks can go back & forth just by tapping instead of swiping
@mattkrick I tried to fix that quickly, but was unable to, as possibly, there is a bug in the library.
Also, since in this PR I only touched settings part of the dialog, I created a separate issue and will look into it: #7040
Is it ok?
@igorlesnenko i think i got it working: https://www.loom.com/share/d9a85b1904be463ea3cb7401e8f4e47d
If you like what you see, go ahead & merge https://github.com/ParabolInc/parabol/pull/7061 into this PR.
aside from that, lgtm
@mattkrick I left comments in your PR: https://github.com/ParabolInc/parabol/pull/7061#pullrequestreview-1071109618
I'm merging this PR for now