parabol icon indicating copy to clipboard operation
parabol copied to clipboard

Bug: Demo started in grouping cannot advance to next

Open Dschoordsch opened this issue 2 years ago • 2 comments

How to reproduce

When accidentally starting the demo in /group phase, the demo cannot be advanced with the next button

Expected

Demo can be advanced

Dschoordsch avatar Jul 26 '22 16:07 Dschoordsch

Relates to: #6946

Dschoordsch avatar Jul 26 '22 16:07 Dschoordsch

Just want to double confirm: If the user goes directly to the /group route with the disabled refresh to start a new demo meeting in https://github.com/ParabolInc/parabol/issues/6946. What the phase does the user click the Start Demo button to start? start the demo directly from the Group stage, or should start with the Reflect stage?

Google Chrome-Retro Meeting  Demo Team-003916-20220809

JimmyLv avatar Aug 09 '22 13:08 JimmyLv

If the demo did not start correctly, i.e. there are no reflections and the user goes to group directly (no existing local demo state), we should show the "Start Demo" button and start from reflect.

Dschoordsch avatar Aug 23 '22 15:08 Dschoordsch

I made the bugfix for the demo state in the PR at https://github.com/ParabolInc/parabol/pull/7131, which means that it will show the "Start Demo" button in /group and thus start normally. Just except for one small issue: the Group dragging effect will not appear immediately, because the BotScript would need to enter everything first before starting the Group.

JimmyLv avatar Aug 30 '22 12:08 JimmyLv

Seems like this is solved with #7131, is that correct @JimmyLv?

Dschoordsch avatar Oct 05 '22 17:10 Dschoordsch

Yes, correct! this issue is already fixed, closed.

JimmyLv avatar Oct 11 '22 03:10 JimmyLv